Closed Bug 718315 Opened 8 years ago Closed 8 years ago

Advanced/Crash Reporter checkbox should be independent of shell service

Categories

(SeaMonkey :: Preferences, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.9

People

(Reporter: InvisibleSmiley, Assigned: InvisibleSmiley)

References

Details

Attachments

(1 file)

See discussion in bug 697453 comments 3 and 4.
Attachment #588754 - Flags: review?(neil)
Comment on attachment 588754 [details] [diff] [review]
patch [Checkin: Comment 3]

I don't actually have a crashreporter-enabled build but I'll assume this works.
Attachment #588754 - Flags: review?(neil) → review+
> See discussion in bug 697453 comments 3 and 4.
Copying them here for the record:

> Jens Hatlak (:InvisibleSmiley)      2012-01-15 09:41:55 PST
> 
> Came here from Help bug 698038. I wondered why the whole Advanced pref pane
> was empty on Linux, and especially why the new group box that was added
> through this bug was missing. Turns out it's because this is false on Linux:
> 
> NS_SHELLSERVICE_CID in Components.classes
> 
> So, looking at base bug 540532 it seems that there's an implementation for
> Linux in the back-end (but not Mac, FWIW). Was that an oversight? If it was
> I think we should move the CrashReportsCheck() call to Startup().
> 
> CC: jh@junetz.de
> [reply] [-] Comment 4 Philip Chee 2012-01-15 10:25:29 PST
> 
> > Was that an oversight?
> In a way. I was porting the Firefox patch and at that time they wrapped the
> crash reports checkbox inside a shell service check:
> 
> http://hg.mozilla.org/mozilla-central/rev/b8586e71aa93#l2.10
> 
> But I missed Bug 652657 Comment 44 since we haven't yet implemented the front
> end for telemetry:
> 
> >>diff --git a/browser/components/preferences/advanced.xul b/browser/components/preferences/advanced.xul
> > 
> >> #ifdef MOZ_CRASHREPORTER
> >>             <checkbox id="submitCrashesBox" flex="1"
> >>                       oncommand="gAdvancedPane.updateSubmitCrashes();"
> >>                       label="&submitCrashes.label;" accesskey="&submitCrashes.accesskey;"/>
> >> #endif
> >>+#endif
> > 
> > Technically I think this should be outside of the HAVE_SHELL_SERVICE ifdef, but I guess you don't need to make that change here.
> 
> So please file a new bug?
Comment on attachment 588754 [details] [diff] [review]
patch [Checkin: Comment 3]

http://hg.mozilla.org/comm-central/rev/f907e1b1efd9
Attachment #588754 - Attachment description: patch → patch [Checkin: Comment 3]
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.9
You need to log in before you can comment on or make changes to this bug.