If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Jetpack checksums list is out of date.

RESOLVED WORKSFORME

Status

addons.mozilla.org Graveyard
Add-on Validation
P1
critical
RESOLVED WORKSFORME
6 years ago
2 years ago

People

(Reporter: kmag, Unassigned)

Tracking

unspecified
6.2.9

Details

(Whiteboard: [ReviewTeam])

The Jetpack API checksum list appears to be out of date. For the vast majority of submissions we receive lately, only a handful of API files pass validation. As we're currently bringing on members of the Jetpack team to help with Jetpack reviews, my normal strategy of asking people to leave those reviews to me is not going to be sufficient.
We need this fixed ASAP, since it hinders our ability to effectively review SDK add-ons.
Severity: major → critical
Priority: -- → P1
Whiteboard: [required amo-editors]
Target Milestone: --- → 6.2.9
(In reply to Kris Maglione [:kmag] from comment #0)
> The Jetpack API checksum list appears to be out of date. For the vast
> majority of submissions we receive lately, only a handful of API files pass
> validation. As we're currently bringing on members of the Jetpack team to
> help with Jetpack reviews, my normal strategy of asking people to leave
> those reviews to me is not going to be sufficient.

An unfortunately manual process:
https://github.com/mozilla/amo-validator/commit/b578f0eb9160328962aa574137cd5dc160eb9e6a
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
This doesn't seem fixed. This add-on, for instance:

https://addons-dev.allizom.org/en-US/firefox/files/browse/132280/

Comes up with only the following matches:

[object Object]::
resources/jid1-jtbfn9onuips4a-at-jetpack-addon-kit-data/: ./python-lib/cuddlefish/tests/bug-588661-files/packages/foo/lib/foo-loader.js,1.0rc4
resources/jid1-jtbfn9onuips4a-at-jetpack-addon-kit-data/test-page-worker.js: ./packages/addon-kit/data/test-page-worker.js,1.0rc4
resources/jid1-jtbfn9onuips4a-at-jetpack-addon-kit-lib/: ./python-lib/cuddlefish/tests/bug-588661-files/packages/foo/lib/foo-loader.js,1.0rc4
resources/jid1-jtbfn9onuips4a-at-jetpack-api-utils-data/: ./python-lib/cuddlefish/tests/bug-588661-files/packages/foo/lib/foo-loader.js,1.0rc4
resources/jid1-jtbfn9onuips4a-at-jetpack-api-utils-lib/: ./python-lib/cuddlefish/tests/bug-588661-files/packages/foo/lib/foo-loader.js,1.0rc4
resources/jid1-jtbfn9onuips4a-at-jetpack-api-utils-lib/dom/events.js: ./packages/api-utils/lib/dom/events.js,1.0rc4
resources/jid1-jtbfn9onuips4a-at-jetpack-api-utils-lib/light-traits.js: ./packages/api-utils/lib/light-traits.js,1.0rc4
resources/jid1-jtbfn9onuips4a-at-jetpack-api-utils-lib/runtime.js: ./packages/api-utils/lib/runtime.js,1.0rc4
resources/jid1-jtbfn9onuips4a-at-jetpack-api-utils-lib/tabs/events.js: ./packages/api-utils/lib/tabs/events.js,1.0rc4
resources/jid1-jtbfn9onuips4a-at-jetpack-api-utils-lib/traits/core.js: ./packages/api-utils/lib/traits/core.js,1.0rc4
resources/jid1-jtbfn9onuips4a-at-jetpack-api-utils-lib/utils/data.js: ./packages/api-utils/lib/utils/data.js,1.0rc4
resources/jid1-jtbfn9onuips4a-at-jetpack-api-utils-lib/utils/thumbnail.js: ./packages/api-utils/lib/utils/thumbnail.js,1.0rc4
resources/jid1-jtbfn9onuips4a-at-jetpack-foo-data/: ./python-lib/cuddlefish/tests/bug-588661-files/packages/foo/lib/foo-loader.js,1.0rc4
resources/jid1-jtbfn9onuips4a-at-jetpack-foo-lib/: ./python-lib/cuddlefish/tests/bug-588661-files/packages/foo/lib/foo-loader.js,1.0rc4
resources/jid1-jtbfn9onuips4a-at-jetpack-foo-tests/: ./python-lib/cuddlefish/tests/bug-588661-files/packages/foo/lib/foo-loader.js,1.0rc4 

Half of those seem to be spurious matches for directories against an
empty file.

It should be more along the lines of:

[object Object]::
bootstrap.js: "Jetpack {3141...3199}: python-lib/cuddlefish/app-extension/bootstrap.js"
components/harness.js: "Jetpack hg3306: python-lib/cuddlefish/app-extension/components/harness.js"
resources/jid1-jtbfn9onuips4a-at-jetpack-addon-kit-data/test-page-mod.html: "Jetpack hg3422: packages/addon-kit/data/test-page-mod.html"
resources/jid1-jtbfn9onuips4a-at-jetpack-addon-kit-data/test-page-worker.html: "Jetpack 0.4: packages/jetpack-core/tests/test-page-worker.html"
resources/jid1-jtbfn9onuips4a-at-jetpack-addon-kit-data/test-page-worker.js: "Jetpack 1.0b5: packages/addon-kit/data/test-page-worker.js"
resources/jid1-jtbfn9onuips4a-at-jetpack-addon-kit-data/test.html: "Jetpack 0.4: packages/jetpack-core/data/test.html"
resources/jid1-jtbfn9onuips4a-at-jetpack-addon-kit-lib/panel.js: "Jetpack hg3505: packages/addon-kit/lib/panel.js"
resources/jid1-jtbfn9onuips4a-at-jetpack-addon-kit-lib/tabs.js: "Jetpack hg3452: packages/addon-kit/lib/tabs.js"
resources/jid1-jtbfn9onuips4a-at-jetpack-addon-kit-lib/widget.js: "Jetpack hg3298: packages/addon-kit/lib/widget.js"
resources/jid1-jtbfn9onuips4a-at-jetpack-addon-kit-lib/windows.js: "Jetpack hg3299: packages/addon-kit/lib/windows.js"
resources/jid1-jtbfn9onuips4a-at-jetpack-api-utils-lib/api-utils.js: "Jetpack hg3289: packages/api-utils/lib/api-utils.js"
resources/jid1-jtbfn9onuips4a-at-jetpack-api-utils-lib/byte-streams.js: "Jetpack hg3298: packages/api-utils/lib/byte-streams.js"
resources/jid1-jtbfn9onuips4a-at-jetpack-api-utils-lib/collection.js: "Jetpack hg3289: packages/api-utils/lib/collection.js"
resources/jid1-jtbfn9onuips4a-at-jetpack-api-utils-lib/content.js: "Jetpack hg3292: packages/api-utils/lib/content.js"
resources/jid1-jtbfn9onuips4a-at-jetpack-api-utils-lib/content/content-proxy.js: "Jetpack hg3431: packages/api-utils/lib/content/content-proxy.js"
resources/jid1-jtbfn9onuips4a-at-jetpack-api-utils-lib/content/loader.js: "Jetpack hg3292: packages/api-utils/lib/content/loader.js"
resources/jid1-jtbfn9onuips4a-at-jetpack-api-utils-lib/content/symbiont.js: "Jetpack hg3431: packages/api-utils/lib/content/symbiont.js"
resources/jid1-jtbfn9onuips4a-at-jetpack-api-utils-lib/content/worker.js: "Jetpack hg3460: packages/api-utils/lib/content/worker.js"
resources/jid1-jtbfn9onuips4a-at-jetpack-api-utils-lib/cortex.js: "Jetpack hg3147: packages/api-utils/lib/cortex.js"
resources/jid1-jtbfn9onuips4a-at-jetpack-api-utils-lib/cuddlefish.js: "Jetpack hg3437: packages/api-utils/lib/cuddlefish.js"
resources/jid1-jtbfn9onuips4a-at-jetpack-api-utils-lib/dom/events.js: "Jetpack 1.0b5: packages/api-utils/lib/dom/events.js"
resources/jid1-jtbfn9onuips4a-at-jetpack-api-utils-lib/errors.js: "Jetpack hg3289: packages/api-utils/lib/errors.js"
resources/jid1-jtbfn9onuips4a-at-jetpack-api-utils-lib/events.js: "Jetpack hg3292: packages/api-utils/lib/events.js"
resources/jid1-jtbfn9onuips4a-at-jetpack-api-utils-lib/events/assembler.js: "Jetpack hg3292: packages/api-utils/lib/events/assembler.js"
resources/jid1-jtbfn9onuips4a-at-jetpack-api-utils-lib/file.js: "Jetpack hg3298: packages/api-utils/lib/file.js"
resources/jid1-jtbfn9onuips4a-at-jetpack-api-utils-lib/hidden-frame.js: "Jetpack hg3298: packages/api-utils/lib/hidden-frame.js"
resources/jid1-jtbfn9onuips4a-at-jetpack-api-utils-lib/light-traits.js: "Jetpack hg1488: packages/api-utils/lib/light-traits.js"
resources/jid1-jtbfn9onuips4a-at-jetpack-api-utils-lib/list.js: "Jetpack hg3296: packages/api-utils/lib/list.js"
resources/jid1-jtbfn9onuips4a-at-jetpack-api-utils-lib/memory.js: "Jetpack hg3306: packages/api-utils/lib/memory.js"
resources/jid1-jtbfn9onuips4a-at-jetpack-api-utils-lib/observer-service.js: "Jetpack hg3298: packages/api-utils/lib/observer-service.js"
resources/jid1-jtbfn9onuips4a-at-jetpack-api-utils-lib/plain-text-console.js: "Jetpack hg3298: packages/api-utils/lib/plain-text-console.js"
resources/jid1-jtbfn9onuips4a-at-jetpack-api-utils-lib/runtime.js: "Jetpack 1.0b5: packages/api-utils/lib/runtime.js"
resources/jid1-jtbfn9onuips4a-at-jetpack-api-utils-lib/securable-module.js: "Jetpack hg3461: packages/api-utils/lib/securable-module.js"
resources/jid1-jtbfn9onuips4a-at-jetpack-api-utils-lib/self-maker.js: "Jetpack hg3455: packages/api-utils/lib/self-maker.js"
resources/jid1-jtbfn9onuips4a-at-jetpack-api-utils-lib/shims.js: "Jetpack hg3289: packages/api-utils/lib/shims.js"
resources/jid1-jtbfn9onuips4a-at-jetpack-api-utils-lib/tabs/events.js: "Jetpack hg1159: packages/api-utils/lib/tabs/events.js"
resources/jid1-jtbfn9onuips4a-at-jetpack-api-utils-lib/tabs/observer.js: "Jetpack hg3301: packages/api-utils/lib/tabs/observer.js"
resources/jid1-jtbfn9onuips4a-at-jetpack-api-utils-lib/tabs/tab.js: "Jetpack hg3452: packages/api-utils/lib/tabs/tab.js"
resources/jid1-jtbfn9onuips4a-at-jetpack-api-utils-lib/tabs/utils.js: "Jetpack hg3107: packages/api-utils/lib/tabs/utils.js"
resources/jid1-jtbfn9onuips4a-at-jetpack-api-utils-lib/text-streams.js: "Jetpack hg3298: packages/api-utils/lib/text-streams.js"
resources/jid1-jtbfn9onuips4a-at-jetpack-api-utils-lib/timer.js: "Jetpack hg3298: packages/api-utils/lib/timer.js"
resources/jid1-jtbfn9onuips4a-at-jetpack-api-utils-lib/traceback.js: "Jetpack hg3298: packages/api-utils/lib/traceback.js"
resources/jid1-jtbfn9onuips4a-at-jetpack-api-utils-lib/traits.js: "Jetpack hg3296: packages/api-utils/lib/traits.js"
resources/jid1-jtbfn9onuips4a-at-jetpack-api-utils-lib/traits/core.js: "Jetpack 0.8: packages/jetpack-core/lib/traits/core.js"
resources/jid1-jtbfn9onuips4a-at-jetpack-api-utils-lib/unload.js: "Jetpack hg3201: packages/api-utils/lib/unload.js"
resources/jid1-jtbfn9onuips4a-at-jetpack-api-utils-lib/url.js: "Jetpack hg3298: packages/api-utils/lib/url.js"
resources/jid1-jtbfn9onuips4a-at-jetpack-api-utils-lib/utils/data.js: "Jetpack hg1159: packages/api-utils/lib/utils/data.js"
resources/jid1-jtbfn9onuips4a-at-jetpack-api-utils-lib/utils/function.js: "Jetpack hg3292: packages/api-utils/lib/utils/function.js"
resources/jid1-jtbfn9onuips4a-at-jetpack-api-utils-lib/utils/thumbnail.js: "Jetpack hg1159: packages/api-utils/lib/utils/thumbnail.js"
resources/jid1-jtbfn9onuips4a-at-jetpack-api-utils-lib/window-utils.js: "Jetpack hg3306: packages/api-utils/lib/window-utils.js"
resources/jid1-jtbfn9onuips4a-at-jetpack-api-utils-lib/windows/dom.js: "Jetpack hg3292: packages/api-utils/lib/windows/dom.js"
resources/jid1-jtbfn9onuips4a-at-jetpack-api-utils-lib/windows/loader.js: "Jetpack hg3292: packages/api-utils/lib/windows/loader.js"
resources/jid1-jtbfn9onuips4a-at-jetpack-api-utils-lib/windows/observer.js: "Jetpack hg3301: packages/api-utils/lib/windows/observer.js"
resources/jid1-jtbfn9onuips4a-at-jetpack-api-utils-lib/windows/tabs.js: "Jetpack hg3452: packages/api-utils/lib/windows/tabs.js"
resources/jid1-jtbfn9onuips4a-at-jetpack-api-utils-lib/xpcom.js: "Jetpack hg3298: packages/api-utils/lib/xpcom.js"
resources/jid1-jtbfn9onuips4a-at-jetpack-api-utils-lib/xul-app.js: "Jetpack hg3289: packages/api-utils/lib/xul-app.js"
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
mbasta ran the script again (maybe I did something wrong).  It's getting reviewed by kumar afaik.  Kumar?
Can someone re-post a link to a jetpack addon that was failing due to checksums out of date?  The link in comment 3 looks like an open search provider not a jetpack.
I cannot reproduce this anymore so I think it is fixed.  I tested with this jetpack https://addons-dev.allizom.org/en-US/editors/review/grid-cert-export -- I uploaded it here https://addons-dev.allizom.org/en-US/developers/addon/validate and did not see any SDK errors.
Status: REOPENED → RESOLVED
Last Resolved: 6 years ago6 years ago
Resolution: --- → FIXED
closing as works for me because no [known] code change was involved in this fix.
Resolution: FIXED → WORKSFORME
Blocks: 698789
Reclassifying editor bugs and changing to a new whiteboard flag. Spam, spam, spam, spam...
Whiteboard: [required amo-editors] → [ReviewTeam]
(Assignee)

Updated

2 years ago
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.