697560 - WebGL Conformance fails on 'read-pixels-test'

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[Kelsey Gilbert [:jgilbert]]

We currently do not generate errors properly in accordance to spec for gl.readPixels, causing us to fail conformance test 'read-pixels-test'.

Comment 1

[Kelsey Gilbert [:jgilbert]]

Attachment: Fix errors generated by WebGL readPixels to bring up to spec

This fixes the argument checking for readPixels to more closely follow spec.

Comment 2

[Kelsey Gilbert [:jgilbert]]

Attachment: Patch 2: Disallow conformance test failures for 'read-pixels-test'

Updates the failed test lists for win/mac/lin.

Comment 3

[Kelsey Gilbert [:jgilbert]]

Matching try: https://tbpl.mozilla.org/?tree=Try&rev=e2772af21681

Comment 4

[Kelsey Gilbert [:jgilbert]]

Attachment: Patch 1: Fix errors generated by WebGL readPixels to bring up to spec

Unbitrotting.

Comment 5

[Kelsey Gilbert [:jgilbert]]

Attachment: Patch 2: Disallow conformance test failures for 'read-pixels-test'

Unbitrot.

Comment 6

[Benoit Jacob [:bjacob] (mostly away)]

Comment on attachment 570031 [details] [diff] [review]
Patch 2: Disallow conformance test failures for 'read-pixels-test'

Review of attachment 570031 [details] [diff] [review]:
-----------------------------------------------------------------

fold into other patch.

Comment 7

[Kelsey Gilbert [:jgilbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/022e7d3042cb

Comment 8

[Kelsey Gilbert [:jgilbert]]

Attachment: Fix errors generated by WebGL readPixels to bring up to spec and disallow conf. fails

r+ carryover from bjacob.

Comment 9

[Kelsey Gilbert [:jgilbert]]

That was what was pushed. I just forgot to upload the new version before pushing.

Comment 10

[Kelsey Gilbert [:jgilbert]]

Removed [inbound] from whiteboard as per https://wiki.mozilla.org/Tree_Rules/Inbound

Comment 11

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

https://hg.mozilla.org/mozilla-central/rev/022e7d3042cb