WebGL Conformance fails on 'read-pixels-test'

RESOLVED FIXED in mozilla10

Status

()

Core
Canvas: WebGL
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: jgilbert, Assigned: jgilbert)

Tracking

unspecified
mozilla10
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 4 obsolete attachments)

(Assignee)

Description

6 years ago
We currently do not generate errors properly in accordance to spec for gl.readPixels, causing us to fail conformance test 'read-pixels-test'.
(Assignee)

Updated

6 years ago
Depends on: 697168
(Assignee)

Comment 1

6 years ago
Created attachment 569787 [details] [diff] [review]
Fix errors generated by WebGL readPixels to bring up to spec

This fixes the argument checking for readPixels to more closely follow spec.
Attachment #569787 - Flags: review?(bjacob)
(Assignee)

Comment 2

6 years ago
Created attachment 569788 [details] [diff] [review]
Patch 2: Disallow conformance test failures for 'read-pixels-test'

Updates the failed test lists for win/mac/lin.
Attachment #569788 - Flags: review?(bjacob)
(Assignee)

Comment 3

6 years ago
Matching try: https://tbpl.mozilla.org/?tree=Try&rev=e2772af21681
(Assignee)

Comment 4

6 years ago
Created attachment 570030 [details] [diff] [review]
Patch 1: Fix errors generated by WebGL readPixels to bring up to spec

Unbitrotting.
Attachment #569787 - Attachment is obsolete: true
Attachment #569787 - Flags: review?(bjacob)
Attachment #570030 - Flags: review?(bjacob)
(Assignee)

Comment 5

6 years ago
Created attachment 570031 [details] [diff] [review]
Patch 2: Disallow conformance test failures for 'read-pixels-test'

Unbitrot.
Attachment #569788 - Attachment is obsolete: true
Attachment #569788 - Flags: review?(bjacob)
Attachment #570031 - Flags: review?(bjacob)
Attachment #570030 - Flags: review?(bjacob) → review+
Comment on attachment 570031 [details] [diff] [review]
Patch 2: Disallow conformance test failures for 'read-pixels-test'

Review of attachment 570031 [details] [diff] [review]:
-----------------------------------------------------------------

fold into other patch.
Attachment #570031 - Flags: review?(bjacob) → review+
(Assignee)

Updated

6 years ago
Blocks: 680721
(Assignee)

Comment 7

6 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/022e7d3042cb
Whiteboard: [inbound]
Target Milestone: --- → mozilla10
(Assignee)

Comment 8

6 years ago
Created attachment 570885 [details] [diff] [review]
Fix errors generated by WebGL readPixels to bring up to spec and disallow conf. fails

r+ carryover from bjacob.
Attachment #570030 - Attachment is obsolete: true
Attachment #570031 - Attachment is obsolete: true
Attachment #570885 - Flags: review+
(Assignee)

Comment 9

6 years ago
That was what was pushed. I just forgot to upload the new version before pushing.
(Assignee)

Comment 10

6 years ago
Removed [inbound] from whiteboard as per https://wiki.mozilla.org/Tree_Rules/Inbound
Whiteboard: [inbound]
https://hg.mozilla.org/mozilla-central/rev/022e7d3042cb
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.