The default bug view has changed. See this FAQ.

ReadPixels, TexImage2D, and TexSubImage2D incorrectly accept untyped array buffers

RESOLVED FIXED in mozilla10

Status

()

Core
Canvas: WebGL
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: jgilbert, Assigned: jgilbert)

Tracking

unspecified
mozilla10
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

6 years ago
The WebGL spec requires that readPixels only takes typed arrays, not untyped array buffers.
(Assignee)

Updated

6 years ago
Summary: ReadPixels incorrectly accepts untyped array buffers → ReadPixels, TexImage2D, and TexSubImage2D incorrectly accept untyped array buffers
(Assignee)

Updated

6 years ago
Blocks: 697560
(Assignee)

Comment 1

6 years ago
Created attachment 569783 [details] [diff] [review]
Remove non-spec ArrayBuffer overloads for readPixels, texImage2D, and texSubImage2D
Attachment #569783 - Flags: review?(bjacob)
(Assignee)

Comment 2

6 years ago
ReadPixels should also no longer need a dummy IDL stub, since there's only one valid set of arguments. I have had trouble actually removing the stub, but the functionality is the same just leaving it in.
(Assignee)

Comment 3

6 years ago
Matching try: https://tbpl.mozilla.org/?tree=Try&rev=997e3381d771
Status: NEW → ASSIGNED
(Assignee)

Updated

6 years ago
Blocks: 697753
(Assignee)

Comment 4

6 years ago
Created attachment 570029 [details] [diff] [review]
Remove non-spec ArrayBuffer overloads for readPixels, texImage2D, and texSubImage2D

Unbitrotted.
Attachment #569783 - Attachment is obsolete: true
Attachment #569783 - Flags: review?(bjacob)
Attachment #570029 - Flags: review?(bjacob)
Attachment #570029 - Flags: review?(bjacob) → review+
(Assignee)

Updated

6 years ago
Blocks: 680721
(Assignee)

Comment 5

6 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/2cd25d4a839b
Whiteboard: [inbound]
Target Milestone: --- → mozilla10
(Assignee)

Comment 6

6 years ago
Removed [inbound] from whiteboard as per https://wiki.mozilla.org/Tree_Rules/Inbound
Whiteboard: [inbound]
https://hg.mozilla.org/mozilla-central/rev/2cd25d4a839b
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.