requestFullScreen should not work on navigated-away documents

RESOLVED FIXED in mozilla10

Status

()

Core
DOM
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Jesse Ruderman, Assigned: cpearce)

Tracking

(Blocks: 2 bugs, {assertion, testcase})

Trunk
mozilla10
assertion, testcase
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [sg:low?][inbound])

Attachments

(3 attachments, 1 obsolete attachment)

(Reporter)

Description

6 years ago
Created attachment 569856 [details]
testcase

== Steps ==

1. Set these prefs:
user_pref("full-screen-api.allow-trusted-requests-only", false);
user_pref("full-screen-api.enabled", true);

2. Load the testcase.

== Result ==

1. Firefox enters full-screen mode.

2. ###!!! ASSERTION: Document should report fullscreen: 'fullscreen', file content/html/content/src/nsGenericHTMLElement.cpp, line 3413

3. ###!!! ASSERTION: Should be in full screen state!: 'doc->IsFullScreenDoc()', file content/html/content/src/nsGenericHTMLElement.cpp, line 3414

== Expected ==

1. The requestFullScreen call should throw.

== Security impact ==

This might be bypass for lack of mozallowfullscreen attribute.
(Reporter)

Comment 1

6 years ago
Created attachment 569857 [details]
assertion stacks
(Assignee)

Updated

6 years ago
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → DUPLICATE
Duplicate of bug: 685402
(Assignee)

Comment 3

6 years ago
I'll reopen this bug and resolve it separately from bug 685402 to simplify patches, reviews, and landings.
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
(Assignee)

Comment 4

6 years ago
Created attachment 570173 [details] [diff] [review]
Patch v1

Patch, with Jesse's testcase. Based on top of bug 688648 and bug 685779, so will hold of on requesting review until they're reviewed.
Assignee: nobody → chris
Status: REOPENED → ASSIGNED
(Assignee)

Comment 5

6 years ago
Created attachment 570855 [details] [diff] [review]
Patch v2

Rebased on top of patch in bug 685779 and bug 688468. Includes test.
Attachment #570173 - Attachment is obsolete: true
Attachment #570855 - Flags: review?(bzbarsky)
Comment on attachment 570855 [details] [diff] [review]
Patch v2

r=me
Attachment #570855 - Flags: review?(bzbarsky) → review+
(Assignee)

Comment 7

6 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/d2bd5990a2fb
(Assignee)

Updated

6 years ago
OS: Mac OS X → All
Hardware: x86_64 → All
Target Milestone: --- → mozilla10
(Assignee)

Updated

6 years ago
Whiteboard: [sg:low?] → [sg:low?][inbound]

Comment 8

6 years ago
https://hg.mozilla.org/mozilla-central/rev/d2bd5990a2fb
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.