If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

You can only "Don't Save" a message once on quit

RESOLVED FIXED in Thunderbird 10.0

Status

Thunderbird
Message Compose Window
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: mconley, Assigned: mconley)

Tracking

unspecified
Thunderbird 10.0
x86
All
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

6 years ago
This was noticed by NeilAway when porting bug 682581 to suite.

Steps to reproduce:

1)  Open two compose windows, and write into each one
2)  In the TB main window, go to File > Quit
3)  In the second compose window, in the confirm prompt that comes up, choose "Don't Save"
4)  In the first compose window, choose "Cancel"
5)  The quit was canceled.  Now try closing the second window.

What happens?

The second window closes without prompting the user.

What's expected?

The window should prompt the user whether or not they want to save, or not save.
(Assignee)

Updated

6 years ago
Assignee: nobody → mconley
Blocks: 682581
(Assignee)

Comment 1

6 years ago
Created attachment 570338 [details] [diff] [review]
Patch v1

The patch proposed for suite in bug 698011 fixes this for me.  Test case included.
Attachment #570338 - Flags: review?(mbanner)
(Assignee)

Updated

6 years ago
Flags: in-testsuite+
(Assignee)

Comment 2

6 years ago
Created attachment 570340 [details] [diff] [review]
Patch v2

Whoops - the comment for the test refers to the suite bug, not the TB bug.  Fixed that.
Attachment #570338 - Attachment is obsolete: true
Attachment #570338 - Flags: review?(mbanner)
Attachment #570340 - Flags: review?(mbanner)
Attachment #570340 - Flags: review?(mbanner) → review+
(Assignee)

Comment 3

6 years ago
Thanks for the review!  Committed as:  http://hg.mozilla.org/comm-central/rev/7e11d75ffd08
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 10.0
You need to log in before you can comment on or make changes to this bug.