Closed
Bug 698255
Opened 13 years ago
Closed 13 years ago
Make pymake runtests.py's grep-for option work
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla10
People
(Reporter: rain1, Assigned: rain1)
References
Details
Attachments
(1 file)
|
812 bytes,
patch
|
khuey
:
review+
|
Details | Diff | Splinter Review |
We didn't actually check for grep-for strings, I found. I couldn't think of a way to write a test for the test harness (a meta-test I guess).
Attachment #570532 -
Flags: review?(khuey)
|
Assignee | |
Updated•13 years ago
|
Attachment #570532 -
Attachment is patch: true
|
|
Assignee | |
Updated•13 years ago
|
Status: NEW → ASSIGNED
Comment on attachment 570532 [details] [diff] [review] patch Review of attachment 570532 [details] [diff] [review]: ----------------------------------------------------------------- Heh
Attachment #570532 -
Flags: review?(khuey) → review+
|
|
Assignee | |
Comment 2•13 years ago
|
||
http://hg.mozilla.org/users/bsmedberg_mozilla.com/pymake/rev/75d1479a6688
|
|
Assignee | |
Comment 3•13 years ago
|
||
Fixed with https://hg.mozilla.org/mozilla-central/rev/d13cb5295a37.
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla11
|
||
Updated•13 years ago
|
Target Milestone: mozilla11 → mozilla10
|
||
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•