Closed Bug 698255 Opened 10 years ago Closed 10 years ago

Make pymake runtests.py's grep-for option work

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla10

People

(Reporter: rain1, Assigned: rain1)

References

Details

Attachments

(1 file)

Attached patch patchSplinter Review
We didn't actually check for grep-for strings, I found.

I couldn't think of a way to write a test for the test harness (a meta-test I guess).
Attachment #570532 - Flags: review?(khuey)
Attachment #570532 - Attachment is patch: true
Blocks: 698257
Status: NEW → ASSIGNED
Comment on attachment 570532 [details] [diff] [review]
patch

Review of attachment 570532 [details] [diff] [review]:
-----------------------------------------------------------------

Heh
Attachment #570532 - Flags: review?(khuey) → review+
Fixed with https://hg.mozilla.org/mozilla-central/rev/d13cb5295a37.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla11
Target Milestone: mozilla11 → mozilla10
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.