The default bug view has changed. See this FAQ.

Make pymake's info behave like GNU make's info

RESOLVED FIXED in mozilla10

Status

()

Core
Build Config
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: sid0, Assigned: sid0)

Tracking

unspecified
mozilla10
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Created attachment 570534 [details] [diff] [review]
patch

From https://www.gnu.org/s/hello/manual/make/Make-Control-Functions.html#Make-Control-Functions:

"[info] does nothing more than print its (expanded) argument(s) to standard output. No makefile name or line number is added. The result of the expansion of this function is the empty string."

Pymake doesn't print anything, though, instead calling log.info. I think it makes sense to have info behave the same as GNU make's info, i.e. as a generic print command.
Attachment #570534 - Flags: review?(khuey)
(Assignee)

Updated

6 years ago
Depends on: 698255
(Assignee)

Comment 1

6 years ago
Created attachment 570635 [details] [diff] [review]
fixed patch

We only support one grep-for predicate at a time...
Attachment #570534 - Attachment is obsolete: true
Attachment #570534 - Flags: review?(khuey)
Attachment #570635 - Flags: review?(khuey)
Attachment #570635 - Flags: review?(khuey) → review+
(Assignee)

Comment 2

6 years ago
http://hg.mozilla.org/users/bsmedberg_mozilla.com/pymake/rev/91b606372a44
(Assignee)

Comment 3

6 years ago
Fixed with https://hg.mozilla.org/mozilla-central/rev/d13cb5295a37.
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
You need to log in before you can comment on or make changes to this bug.