Last Comment Bug 698261 - Remove the aElementType argument of NS_NewElement
: Remove the aElementType argument of NS_NewElement
Status: RESOLVED FIXED
[qa-]
:
Product: Core
Classification: Components
Component: DOM (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla11
Assigned To: :Ms2ger (⌚ UTC+1/+2)
:
:
Mentors:
Depends on:
Blocks: 697210
  Show dependency treegraph
 
Reported: 2011-10-30 05:40 PDT by :Ms2ger (⌚ UTC+1/+2)
Modified: 2011-11-16 10:24 PST (History)
1 user (show)
Ms2ger: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch v1 (13.45 KB, patch)
2011-10-30 06:01 PDT, :Ms2ger (⌚ UTC+1/+2)
bzbarsky: review+
Details | Diff | Splinter Review

Description :Ms2ger (⌚ UTC+1/+2) 2011-10-30 05:40:19 PDT

    
Comment 1 :Ms2ger (⌚ UTC+1/+2) 2011-10-30 06:01:39 PDT
Created attachment 570541 [details] [diff] [review]
Patch v1
Comment 2 Boris Zbarsky [:bz] (still a bit busy) 2011-10-30 11:30:28 PDT
Comment on attachment 570541 [details] [diff] [review]
Patch v1

Why do you need the on-stack nodeInfo?  You can just do:

  PRInt32 ns = aNodeInfo.get()->NamespaceID();

right?

r=me with that.
Comment 3 :Ms2ger (⌚ UTC+1/+2) 2011-10-30 12:53:14 PDT
I guess I can... It's just that playing around with already_AddRefed pointers scares me a little.
Comment 4 :Ms2ger (⌚ UTC+1/+2) 2011-11-16 10:24:49 PST
https://hg.mozilla.org/mozilla-central/rev/1a9c14f23f32

Note You need to log in before you can comment on or make changes to this bug.