698272 - Long attachment file name screws up message reader UI for messages with single attachment

Status: RESOLVED FIXED

(Thunderbird :: Message Reader UI, defect)

Description

[Thomas D. (:thomas8)]

Regression (works in TB 7, broken on trunk, didn't check other versions):
For messages with a single attachment, attachment file names that are longer than the dedicated space on the attachment pane header will screw up the whole message reader UI by pushing message header and message body to the right beyond the screen.

STR

1) from main 3-pane, view message with single attachment which has a long file name
2) drag the border of the folder pane to the right to reduce the width of message list and message preview

Actual result
- we no longer truncate the middle of the clickable attachment file name on attachment header bar (regression, works in TB 7, broken on trunk, didn't check other versions)
- message header and message body are pushed to the right beyond the screen -> whole UI is screwed up

Expected result
- truncate the middle of long attachment file name on attachment header bar (as we do in TB 7)
- thus avoid all the screwed-UI problems

Comment 1

[Thomas D. (:thomas8)]

For smaller screens, this will make the message reader UI completely unusable without any way of recovery -> major!

Comment 2

[rsx11m]

Apparently fall-out from bug 654222. I didn't see this with multiple attachments for testing bug 697870, but then, didn't test it with a single attachment either.

Comment 3

[Jim Porter (:squib)]

(In reply to rsx11m from comment #2)
> Apparently fall-out from bug 654222.

Nope, bug 680695.

Comment 4

[Jim Porter (:squib)]

Taking. This is really easy to fix, but I'm going to write a test for it as penance for screwing it up to begin with.

Comment 5

[Jim Porter (:squib)]

Attachment: Fix this and test it

Here's a patch, complete with tests that fail without the patch and pass with it. Thankfully, it's a very simple patch too!

Comment 6

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 574546 [details] [diff] [review]
Fix this and test it

Review of attachment 574546 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, fixes the bug, and has a test.  r=me!

Thanks,
Blake.

Comment 7

[Jim Porter (:squib)]

Checked in: http://hg.mozilla.org/comm-central/rev/c746aa0555d8

Comment 8

[Mark Banner (:standard8)]

Checked into aurora:

http://hg.mozilla.org/releases/comm-aurora/rev/ad8fbea7f9e2