Last Comment Bug 698706 - Regression in reordering due to bidi isolation of block elements with display: inline
: Regression in reordering due to bidi isolation of block elements with display...
Status: RESOLVED FIXED
: regression
Product: Core
Classification: Components
Component: Layout: Text (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla10
Assigned To: Simon Montagu :smontagu
:
Mentors:
Depends on: 704837 731594
Blocks: 613149
  Show dependency treegraph
 
Reported: 2011-11-01 03:57 PDT by Simon Montagu :smontagu
Modified: 2012-10-13 10:10 PDT (History)
2 users (show)
smontagu: in‑testsuite?
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Testcase minimized from Facebook ticker (617 bytes, text/html)
2011-11-01 03:57 PDT, Simon Montagu :smontagu
no flags Details
Patch (5.15 KB, patch)
2011-11-06 06:57 PST, Simon Montagu :smontagu
roc: review+
Details | Diff | Review
Reftest (1.84 KB, patch)
2011-11-06 06:57 PST, Simon Montagu :smontagu
roc: review+
Details | Diff | Review

Description Simon Montagu :smontagu 2011-11-01 03:57:14 PDT
Created attachment 570959 [details]
Testcase minimized from Facebook ticker

Discovered dogfooding on Facebook with Hebrew UI.
Comment 1 Boris Zbarsky [:bz] (Out June 25-July 6) 2011-11-01 08:40:20 PDT
This is the:

64  * "When a block element that does not have a dir attribute is transformed to
65  * the style of an inline element by a style sheet, the resulting presentation
66  * should be equivalent, in terms of bidirectional formatting, to the
67  * formatting obtained by explicitly adding a dir attribute (assigned the
68  * inherited value) to the transformed element." */

spec quote in html.css, right?

What does HTML5 say about this?
Comment 2 Simon Montagu :smontagu 2011-11-01 13:44:49 PDT
For some values of "this is", yes. By which I mean that in principle we do the right thing -- http://dev.w3.org/html5/spec/Overview.html#flow-content-1 says that block elements should have unicode-bidi: isolate, and bug 613149 changed html.css to give it to them -- but the implementation of bidi isolation is currently buggy. I think I have a fix, currently waiting for results from tryserver.
Comment 3 Simon Montagu :smontagu 2011-11-06 06:57:19 PST
Created attachment 572295 [details] [diff] [review]
Patch

This is really the same issue that I was trying to fix in the last round of changes to bug 613149, as discussed in bug 613149 comment 18-20. Reusing isFirstFrame and isLastFrame to determine whether the sub-paragraph is (or has) continuations was wrong: the correct test is on the continuations of the containing element, i.e. the element with "unicode-bidi: -moz-isolate",
Comment 4 Simon Montagu :smontagu 2011-11-06 06:57:56 PST
Created attachment 572296 [details] [diff] [review]
Reftest

Note You need to log in before you can comment on or make changes to this bug.