The default bug view has changed. See this FAQ.

Regression in reordering due to bidi isolation of block elements with display: inline

RESOLVED FIXED in mozilla10

Status

()

Core
Layout: Text
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: smontagu, Assigned: smontagu)

Tracking

({regression})

Trunk
mozilla10
regression
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite ?

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

(Assignee)

Description

6 years ago
Created attachment 570959 [details]
Testcase minimized from Facebook ticker

Discovered dogfooding on Facebook with Hebrew UI.
This is the:

64  * "When a block element that does not have a dir attribute is transformed to
65  * the style of an inline element by a style sheet, the resulting presentation
66  * should be equivalent, in terms of bidirectional formatting, to the
67  * formatting obtained by explicitly adding a dir attribute (assigned the
68  * inherited value) to the transformed element." */

spec quote in html.css, right?

What does HTML5 say about this?
(Assignee)

Comment 2

6 years ago
For some values of "this is", yes. By which I mean that in principle we do the right thing -- http://dev.w3.org/html5/spec/Overview.html#flow-content-1 says that block elements should have unicode-bidi: isolate, and bug 613149 changed html.css to give it to them -- but the implementation of bidi isolation is currently buggy. I think I have a fix, currently waiting for results from tryserver.
(Assignee)

Comment 3

6 years ago
Created attachment 572295 [details] [diff] [review]
Patch

This is really the same issue that I was trying to fix in the last round of changes to bug 613149, as discussed in bug 613149 comment 18-20. Reusing isFirstFrame and isLastFrame to determine whether the sub-paragraph is (or has) continuations was wrong: the correct test is on the continuations of the containing element, i.e. the element with "unicode-bidi: -moz-isolate",
Attachment #572295 - Flags: review?(roc)
(Assignee)

Comment 4

6 years ago
Created attachment 572296 [details] [diff] [review]
Reftest
Assignee: nobody → smontagu
Attachment #572296 - Flags: review?(roc)
Attachment #572295 - Flags: review?(roc) → review+
Attachment #572296 - Flags: review?(roc) → review+
(Assignee)

Comment 5

6 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/749fa4c40b38
https://hg.mozilla.org/integration/mozilla-inbound/rev/00b0ddf1ab96
Flags: in-testsuite?
Target Milestone: --- → mozilla10
https://hg.mozilla.org/mozilla-central/rev/749fa4c40b38
https://hg.mozilla.org/mozilla-central/rev/00b0ddf1ab96
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
(Assignee)

Updated

5 years ago
Depends on: 704837

Updated

5 years ago
Depends on: 731594
You need to log in before you can comment on or make changes to this bug.