69872 - [API] work on |nsDependentC?String|

Status: RESOLVED FIXED

(Core :: XPCOM, defect, P2)

Description

[Scott Collins]

Specific tasks:

  - rename to |nsLocalString| (is this the best name)
  - make |Rebind|able, a la |nsSlidingSubstring|

we'll keep |NS_LITERAL_STRING| with the same name.

Comment 1

[Scott Collins]

and inherit from a common flat class that the converting classes can also
inherit from ... making use of |NS_LITERAL_STRING| a little smoother

Comment 2

[Scott Collins]

much of this has been checked in on the STRING_081_BRANCH; when the branch is
merged into the trunk, I'll close this bug

Comment 3

[Scott Collins]

(mass change) didn't get these in for target milestone mozilla0.8.1 but they are
very close.  Moving all to mozilla0.9.

Comment 4

[Scott Collins]

Fixed the name and other things, but it's not quite re-bindable yet.  Leaving
this bug open.

Comment 5

[Scott Collins]

These are the 0.9 bugs that didn't make it, and that I intend to fix in 0.9.1

Comment 6

[Scott Collins]

re-targeting milestones, starting from a clean slate

Comment 7

[Scott Collins]

All planned string API fixes need to be in by mozilla1.0.

Comment 8

[Scott Collins]

These classes have been renamed as per bug #75220.  Changing summary accordingly.

Comment 9

[Scott Collins]

Attachment: this patch makes |nsDependentC?String| rebindable, factors the constructors, and fixes |const| issues

Comment 10

[Peter "jag" Annema]

scc, what do you mean with "immutable" when you justify making the
copy-assignment operator private? That comment just looks a bit odd, since one
can change (mutate) the object through |Rebind|.

Other than that, r=jag.

Comment 11

[Scott Collins]

|nsDependentC?String| is like a pointer to |const|, rather than a
|const|-pointer.  Sure, you can make it point to some other buffer ... but you
can't make changes within the buffer it points to through _it_.  Perhaps a
better analogy is a reference.  Assignment into a reference makes changes in the
thing the reference is bound to, it doesn't rebind the reference itself.
Assignment into _any_ of the strings (at least conceptually) makes changes
within the characters that string is managing.  So if you have a buffer, make an
|nsDependentC?String| point to it, and then assign another string into your
dependent string, at least conceptually, were this allowed, I would need to
write those new characters into the buffer the dependent string was managing.
Someday, I may even make |nsDependentC?String| do this, or make a new class that
does.  This is why |Rebind| is distinct.

This is the same as it is in |nsSlidingSubstring|, and was unchanged by this
patch.  Does this make sense?

Comment 12

[Peter "jag" Annema]

Perfect sense (the "Doh! Why didn't I see it like that the first time?" kind).
r=jag.

Comment 13

[Johnny Stenback (:jst)]

sr=jst

Comment 14

[Scott Collins]

fix checked in