698914 - User with deleted Voucher shows no voucher

Status: RESOLVED INVALID

(Participation Infrastructure :: Phonebook, defect, P2)

Description

[tofumatt [:tofumatt]]

An auto-vouched user appears vouchless, but so does a user whose voucher deleted their account (the only evidence of a deleted voucher is an HTML comment).

Steps to reproduce:

1. Bob signs up
2. Jill vouches Bob
3. Jill deletes her account

Expected Result:

Bob's account shows either "Voucher: Jill (Deleted)" or "Voucher: No longer active".

Actual Result:

It looks like Bob was auto-vouched or not vouched because there's no evidence of his voucher.

We should fix this in 1.2. So I'ma do that.

Comment 1

[[github robot]]

Commit pushed to https://github.com/mozilla/mozillians

https://github.com/mozilla/mozillians/commit/4dee12a31c573a7cce367f522d240c4bf303f457
Display "voucher deleted" (fix bug 698914)

Comment 2

[Rebecca Billings [:rbillings]]

blocked by https://bugzilla.mozilla.org/show_bug.cgi?id=712172

Comment 3

[Matt Brandt [:mbrandt]]

Blocked by https://bugzilla.mozilla.org/show_bug.cgi?id=706698

Comment 4

[Matt Brandt [:mbrandt]]

Attachment: qa - vouched by field not present

On dev - The "vouched by" field is not present in [e-mail]'s profile.

Comment 5

[Justin Crawford [:hoosteeno] [:jcrawford]]

Attachment: screenshot showing the results of a deleted voucher on the vouchee's profile

williamr and I just tested; this bug is still happening (see new attachment). Briefly: When the voucher's account is deleted, the vouchee's profile gets bad data.

tofumatt, do you think your code will still fix the issue? If so we should ship!

Comment 7

[tofumatt [:tofumatt]]

Hi there,

I'm really out of the loop on what's happening in this code base. My code here is over a year old. So I really don't know.

I thought it was already merged into master, so if this bug was reopened, evidently it didn't work.

Comment 8

[Nikos Roussos [:comzeradd]]

This is invalid after vouching system refactoring.