698929 - Implement event.stopImmediatePropagation

Status: RESOLVED FIXED

(Core :: DOM: Events, enhancement)

Description

[David Bruant]

This function (http://www.w3.org/TR/DOM-Level-3-Events/#events-event-type-stopImmediatePropagation ) is implemented in Chrome, Safari and IE9 (according to http://samples.msdn.microsoft.com/ietestcenter/#webapps ) but still lacks in Firefox. It can be useful to ensure security (make sure that only the event handler you decided run, for instance).

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

(In reply to David Bruant from comment #0)
> (make sure that
> only the event handler you decided run, for instance).
It can't ensure that. There can be listeners in the list before your listener.

Comment 2

[David Bruant]

(In reply to Olli Pettay [:smaug] from comment #1)
> (In reply to David Bruant from comment #0)
> > (make sure that
> > only the event handler you decided run, for instance).
> It can't ensure that. There can be listeners in the list before your
> listener.
True. I meant "under the condition that you run first".

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Attachment: patch

the interesting part is in the beginning. Rest is mainly just (automatic) uuid changes.
Uploaded to tryserver.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Note, the patch gives IE9/DOM4 behavior. Webkit does something a bit different with the flags,
and I haven't understood what Opera does.

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Or, hmm, does IE9 still do something else. I need to test.

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

So, IE9 clears propagation flags after dispatching an event.
Gecko kinds of does that also atm (unless system group listener calls stopPropagation, but that is a bug.)
I think IE9's behavior is better than what DOM4 says (and no one implements that part of DOM4 correctly anyway).

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

Attachment: patch

Simpler, and keeps more of the old behavior, and IE9 seems to behave this way.
(I'll file spec bugs)

Comment 8

[Olli Pettay [:smaug][[e-mail]]]

Attachment: up-to-date

Comment 9

[Olli Pettay [:smaug][[e-mail]]]

https://hg.mozilla.org/mozilla-central/rev/ae9e5bf847fc

Comment 10

[David Bruant]

(In reply to Olli Pettay [:smaug] from comment #7)
> (I'll file spec bugs)
Did you? Where can i follow progress on that?

Doc: https://developer.mozilla.org/en/DOM/event.stopImmediatePropagation
https://developer.mozilla.org/en/Firefox_10_for_developers#DOM

Comment 11

[Olli Pettay [:smaug][[e-mail]]]

Sorry, I haven't filed them yet. I need to re-review DOM4's event handling fully, since it seems
to have some minor problems there and there. (D3E kind of don't have those problems, I think,
because it leaves some cases undefined.)