Closed Bug 698929 Opened 8 years ago Closed 8 years ago

Implement event.stopImmediatePropagation

Categories

(Core :: DOM: Events, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla10

People

(Reporter: bruant.d, Assigned: smaug)

References

(Depends on 1 open bug, )

Details

(Keywords: dev-doc-complete)

Attachments

(2 files, 1 obsolete file)

This function (http://www.w3.org/TR/DOM-Level-3-Events/#events-event-type-stopImmediatePropagation ) is implemented in Chrome, Safari and IE9 (according to http://samples.msdn.microsoft.com/ietestcenter/#webapps ) but still lacks in Firefox. It can be useful to ensure security (make sure that only the event handler you decided run, for instance).
Severity: normal → enhancement
Keywords: dev-doc-needed
OS: Linux → All
Hardware: x86 → All
(In reply to David Bruant from comment #0)
> (make sure that
> only the event handler you decided run, for instance).
It can't ensure that. There can be listeners in the list before your listener.
(In reply to Olli Pettay [:smaug] from comment #1)
> (In reply to David Bruant from comment #0)
> > (make sure that
> > only the event handler you decided run, for instance).
> It can't ensure that. There can be listeners in the list before your
> listener.
True. I meant "under the condition that you run first".
Assignee: nobody → bugs
Attached patch patch (obsolete) — Splinter Review
the interesting part is in the beginning. Rest is mainly just (automatic) uuid changes.
Uploaded to tryserver.
Attachment #571467 - Flags: review?(jst)
Note, the patch gives IE9/DOM4 behavior. Webkit does something a bit different with the flags,
and I haven't understood what Opera does.
Or, hmm, does IE9 still do something else. I need to test.
So, IE9 clears propagation flags after dispatching an event.
Gecko kinds of does that also atm (unless system group listener calls stopPropagation, but that is a bug.)
I think IE9's behavior is better than what DOM4 says (and no one implements that part of DOM4 correctly anyway).
Attached patch patchSplinter Review
Simpler, and keeps more of the old behavior, and IE9 seems to behave this way.
(I'll file spec bugs)
Attachment #571467 - Attachment is obsolete: true
Attachment #571467 - Flags: review?(jst)
Attachment #571648 - Flags: review?(jst)
Attachment #571648 - Flags: review?(jst) → review+
Attached patch up-to-dateSplinter Review
https://hg.mozilla.org/mozilla-central/rev/ae9e5bf847fc
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Depends on: 699925
Target Milestone: --- → mozilla10
(In reply to Olli Pettay [:smaug] from comment #7)
> (I'll file spec bugs)
Did you? Where can i follow progress on that?

Doc: https://developer.mozilla.org/en/DOM/event.stopImmediatePropagation
https://developer.mozilla.org/en/Firefox_10_for_developers#DOM
Sorry, I haven't filed them yet. I need to re-review DOM4's event handling fully, since it seems
to have some minor problems there and there. (D3E kind of don't have those problems, I think,
because it leaves some cases undefined.)
Depends on: 1503555
You need to log in before you can comment on or make changes to this bug.