Implement event.stopImmediatePropagation in workers

RESOLVED FIXED in mozilla10

Status

()

Core
DOM
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: smaug, Assigned: smaug)

Tracking

unspecified
mozilla10
Points:
---

Firefox Tracking Flags

(firefox10-)

Details

Attachments

(2 attachments)

6.19 KB, patch
Ben Turner (not reading bugmail, use the needinfo flag!)
: review+
Details | Diff | Splinter Review
6.19 KB, patch
Ben Turner (not reading bugmail, use the needinfo flag!)
: review+
Details | Diff | Splinter Review
(Assignee)

Description

6 years ago
And again I forgot something from workers because idl files aren't utilized there :(
(Assignee)

Updated

6 years ago
tracking-firefox10: --- → ?
(Assignee)

Comment 1

6 years ago
Created attachment 572225 [details] [diff] [review]
patch
Assignee: nobody → bugs
Attachment #572225 - Flags: review?(bent.mozilla)
Comment on attachment 572225 [details] [diff] [review]
patch

Review of attachment 572225 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/workers/Events.cpp
@@ +332,5 @@
> +  StopImmediatePropagation(JSContext* aCx, uintN aArgc, jsval* aVp)
> +  {
> +    JSObject* obj = JS_THIS_OBJECT(aCx, aVp);
> +
> +    Event* event = GetInstancePrivate(aCx, obj, sFunctions[0].name);

Nit: you want sFunctions[1] here.
Attachment #572225 - Flags: review?(bent.mozilla) → review+
(Assignee)

Comment 3

6 years ago
Created attachment 572227 [details] [diff] [review]
patch
Attachment #572227 - Flags: review?(bent.mozilla)
Comment on attachment 572227 [details] [diff] [review]
patch

Thanks
Attachment #572227 - Flags: review?(bent.mozilla) → review+
(Assignee)

Comment 5

6 years ago
https://hg.mozilla.org/mozilla-central/rev/7e28b68cf25d
Thank you for the quick review.
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED

Updated

6 years ago
OS: Linux → All
Hardware: x86_64 → All
Target Milestone: --- → mozilla10

Updated

5 years ago
tracking-firefox10: ? → -
You need to log in before you can comment on or make changes to this bug.