699925 - Implement event.stopImmediatePropagation in workers

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

And again I forgot something from workers because idl files aren't utilized there :(

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Attachment: patch

Comment 2

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 572225 [details] [diff] [review]
patch

Review of attachment 572225 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/workers/Events.cpp
@@ +332,5 @@
> +  StopImmediatePropagation(JSContext* aCx, uintN aArgc, jsval* aVp)
> +  {
> +    JSObject* obj = JS_THIS_OBJECT(aCx, aVp);
> +
> +    Event* event = GetInstancePrivate(aCx, obj, sFunctions[0].name);

Nit: you want sFunctions[1] here.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Attachment: patch

Comment 4

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 572227 [details] [diff] [review]
patch

Thanks

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

https://hg.mozilla.org/mozilla-central/rev/7e28b68cf25d
Thank you for the quick review.