Note: There are a few cases of duplicates in user autocompletion which are being worked on.

GCLI should use a sensible naming convention for its class names

RESOLVED FIXED in Firefox 11

Status

()

Firefox
Developer Tools: Console
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: jwalker, Assigned: jwalker)

Tracking

unspecified
Firefox 11
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [fixed-in-fx-team])

Attachments

(2 attachments, 1 obsolete attachment)

Comment hidden (empty)
Status: NEW → ASSIGNED
Summary: GCLI should use a sensible naming convention for it's class names → GCLI should use a sensible naming convention for its class names
Created attachment 573173 [details] [diff] [review]
upload 1
See https://tbpl.mozilla.org/?tree=Try&rev=2a2808e08d26
Created attachment 573188 [details]
the full css, post patch
This bug and bug 692742 account for quite a bit of churn to gcli.css. It might help to look at attachment 573188 [details] to see how things end up rather than wade through the patches.

Also you can look at/comment on https://github.com/mozilla/gcli/pull/44
Attachment #573173 - Flags: feedback?(paul)
Depends on: 692742

Comment 5

6 years ago
Comment on attachment 573173 [details] [diff] [review]
upload 1

Review of attachment 573173 [details] [diff] [review]:
-----------------------------------------------------------------

f+ if gcliVALID is replaced with "gcli-in-valid".

::: browser/devtools/webconsole/gcli.jsm
@@ +5583,4 @@
>      if (!this.element) {
>        this.elementCreated = true;
>        this.element = dom.createElement(this.document, 'div');
> +      this.element.className = 'gcli-in-complete gcliVALID';

Did you mean "gcli-in-valid"?
(In reply to Paul Rouget [:paul] from comment #5)
> Comment on attachment 573173 [details] [diff] [review] [diff] [details] [review]
> upload 1
> 
> Review of attachment 573173 [details] [diff] [review] [diff] [details] [review]:
> -----------------------------------------------------------------
> 
> f+ if gcliVALID is replaced with "gcli-in-valid".
> 
> ::: browser/devtools/webconsole/gcli.jsm
> @@ +5583,4 @@
> >      if (!this.element) {
> >        this.elementCreated = true;
> >        this.element = dom.createElement(this.document, 'div');
> > +      this.element.className = 'gcli-in-complete gcliVALID';
> 
> Did you mean "gcli-in-valid"?

Yes. Good spot. It's fixed here: https://github.com/joewalker/gcli/commit/74b0d8fcb4d365313ababf2730558dc79819362a
Which is part of bug 699411
The fix above isn't part of attachment 573173 [details] [diff] [review], but it will be part of  bug 702621.

The reason for me wanting to avoid making new patches is that I fixed a bug in dryice (our build tool) which creates some churn in the way templates are serialized. Undoing this would cause quite a bit of patch churn, so unless there is actual breakage, I'd like to delay the fixes until the churn has landed.
Comment on attachment 573173 [details] [diff] [review]
upload 1


Dave: See also https://github.com/mozilla/gcli/pull/44
Attachment #573173 - Flags: review?(dcamp)
Attachment #573173 - Flags: review?(dao)

Updated

6 years ago
Attachment #573173 - Flags: review?(dcamp) → review+
Created attachment 575165 [details] [diff] [review]
upload 2

Rebase to fix paths.

Dao: Please could you review this patch - it's taking a long time to land. Thanks.
Attachment #573173 - Attachment is obsolete: true
Attachment #573173 - Flags: review?(dao)
Attachment #573173 - Flags: feedback?(paul)
Attachment #575165 - Flags: review?(dao)
Comment on attachment 575165 [details] [diff] [review]
upload 2

I have no idea what "af" and "in" mean...
Attachment #575165 - Flags: review?(dao) → review+
(In reply to Dão Gottwald [:dao] from comment #10)
> Comment on attachment 575165 [details] [diff] [review] [diff] [details] [review]
> upload 2
> 
> I have no idea what "af" and "in" mean...

I think that probably doesn't worry me. If you knew that af stood for argfetch, would you be any the wiser? Either can be found easily in a search for those that want to know more.

'in' stands for input, by the way.
https://tbpl.mozilla.org/?tree=Try&rev=47353dce1691
Moving GCLI bugs to Developer Tools: Console. Filter on 'baked beans are off'.
Component: Developer Tools → Developer Tools: Console
Whiteboard: [land-in-fx-team]
Blocks: 701664
https://hg.mozilla.org/integration/fx-team/rev/9049e597d6ba
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/9049e597d6ba
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 11
You need to log in before you can comment on or make changes to this bug.