Closed Bug 700036 Opened 8 years ago Closed 8 years ago

Put the style inspector into a xul document.

Categories

(DevTools :: Inspector, defect, P1)

10 Branch
defect

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 10

People

(Reporter: dcamp, Assigned: dao)

References

Details

Attachments

(1 file, 1 obsolete file)

Using an xhtml document is making rtl troublesome.
OS: Mac OS X → All
Hardware: x86 → All
I'll give this a try.
Assignee: nobody → dao
The rule view needs similar treatment, and shares css with style inspector.

The code namespaces its elements already, should be fairly easy to stick it in a xul document instead of xhtml.
Attached patch patch (obsolete) — Splinter Review
This seems to work as far as I tested it manually. I'm also sending it to the try server at this moment.
Attachment #572224 - Flags: review?(dcamp)
Comment on attachment 572224 [details] [diff] [review]
patch

Review of attachment 572224 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/styleinspector/cssruleview.xhtml
@@ -1,4 @@
> -<!DOCTYPE html [
> -  <!ENTITY % htmlDTD PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "DTD/xhtml1-strict.dtd">
> -  %htmlDTD;
> -  <!ENTITY % inspectorDTD SYSTEM "chrome://browser/locale/styleinspector.dtd">

This bit required a small change because of bug 699968 landing in the interim, will upload the new patch.
Attachment #572224 - Flags: review?(dcamp) → review+
Tests pass locally on my mac.
Blocks: 700061
Blocks: 698762
No longer blocks: 700061
Try run for 3ea11cc093b1 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=3ea11cc093b1
Results (out of 21 total builds):
    success: 19
    warnings: 2
Builds available at http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/dgottwald@mozilla.com-3ea11cc093b1
Priority: -- → P1
https://hg.mozilla.org/integration/fx-team/rev/8ce6a152cfb1

Thanks for the help, Dao.
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/8ce6a152cfb1
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 10
Depends on: 700243
Whiteboard: [fixed-in-fx-team]
Component: Developer Tools → Developer Tools: Inspector
QA Contact: developer.tools → developer.tools.inspector
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.