Closed Bug 700243 Opened 8 years ago Closed 8 years ago

Rename csshtmltree.xul's 'header' class

Categories

(DevTools :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 10

People

(Reporter: dao, Assigned: dao)

References

Details

(Whiteboard: [styleinspector])

Attachments

(1 file)

Bug 700036 made csshtmltree.xul include global.css. global.css sets font-weight:bold for .header, which isn't wanted here. The class needs to be renamed.
OS: Windows 7 → All
Hardware: x86_64 → All
Attached patch patchSplinter Review
Attachment #572418 - Flags: review?(dcamp)
Assignee: nobody → dao
Status: NEW → ASSIGNED
Attachment #572418 - Flags: review?(mihai.sucan)
Comment on attachment 572418 [details] [diff] [review]
patch

Review of attachment 572418 [details] [diff] [review]:
-----------------------------------------------------------------

Patch looks good.

Dão, thank you very much for your contributions to the style inspector! Very much appreciated!

One comment: "show user styles" seems to not be vertically aligned in the middle when compared with the search field. Noticed this?
Attachment #572418 - Flags: review?(mihai.sucan) → review+
Whiteboard: [styleinspector]
(In reply to Mihai Sucan [:msucan] from comment #2)
> One comment: "show user styles" seems to not be vertically aligned in the
> middle when compared with the search field. Noticed this?

Using a xul:checkbox would probably fix this. (bug 699002)
Attachment #572418 - Flags: review?(dcamp)
https://hg.mozilla.org/integration/fx-team/rev/9ba11f3d00f8
Target Milestone: --- → Firefox 10
https://hg.mozilla.org/mozilla-central/rev/9ba11f3d00f8
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.