Last Comment Bug 700243 - Rename csshtmltree.xul's 'header' class
: Rename csshtmltree.xul's 'header' class
Status: RESOLVED FIXED
[styleinspector]
:
Product: Firefox
Classification: Client Software
Component: Developer Tools (show other bugs)
: Trunk
: All All
: -- normal (vote)
: Firefox 10
Assigned To: Dão Gottwald [:dao]
:
: J. Ryan Stinnett [:jryans] (use ni?)
Mentors:
Depends on:
Blocks: 700036
  Show dependency treegraph
 
Reported: 2011-11-07 01:37 PST by Dão Gottwald [:dao]
Modified: 2011-11-07 07:16 PST (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (8.87 KB, patch)
2011-11-07 03:34 PST, Dão Gottwald [:dao]
mihai.sucan: review+
Details | Diff | Splinter Review

Description Dão Gottwald [:dao] 2011-11-07 01:37:11 PST
Bug 700036 made csshtmltree.xul include global.css. global.css sets font-weight:bold for .header, which isn't wanted here. The class needs to be renamed.
Comment 1 Dão Gottwald [:dao] 2011-11-07 03:34:07 PST
Created attachment 572418 [details] [diff] [review]
patch
Comment 2 Mihai Sucan [:msucan] 2011-11-07 04:38:34 PST
Comment on attachment 572418 [details] [diff] [review]
patch

Review of attachment 572418 [details] [diff] [review]:
-----------------------------------------------------------------

Patch looks good.

Dão, thank you very much for your contributions to the style inspector! Very much appreciated!

One comment: "show user styles" seems to not be vertically aligned in the middle when compared with the search field. Noticed this?
Comment 3 Dão Gottwald [:dao] 2011-11-07 04:43:54 PST
(In reply to Mihai Sucan [:msucan] from comment #2)
> One comment: "show user styles" seems to not be vertically aligned in the
> middle when compared with the search field. Noticed this?

Using a xul:checkbox would probably fix this. (bug 699002)
Comment 4 Dão Gottwald [:dao] 2011-11-07 04:54:34 PST
https://hg.mozilla.org/integration/fx-team/rev/9ba11f3d00f8
Comment 5 Rob Campbell [:rc] (:robcee) 2011-11-07 07:16:33 PST
https://hg.mozilla.org/mozilla-central/rev/9ba11f3d00f8

Note You need to log in before you can comment on or make changes to this bug.