Closed Bug 700042 Opened 8 years ago Closed 8 years ago
"Syntax Highlighting" button in view source-code menu doesn't work
User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:10.0a1) Gecko/20111105 Firefox/10.0a1 Build ID: 20111105031111 Steps to reproduce: Click on the "Syntax Highlighting" menu item on the view-source page. Actual results: The menu item is uncheck, but nothing happened to the code. Expected results: The code should be discolored.
Confirming this on Linux with latest nightly.
Status: UNCONFIRMED → NEW
Ever confirmed: true
This either needs to be fixed before Tuesday. Otherwise either the feature or menu choice needs to be removed after Firefox 10 goes to Aurora.
Not strictly a regression, but bug 482921 added a non-functional menu choice which would seem to be a bad thing to have in a released product.
Component: Developer Tools → HTML: Parser
Product: Firefox → Core
QA Contact: developer.tools → parser
Moved to Core:HTML Parser, which is where bug 482921 was filed.
(In reply to Bill Gianopoulos from comment #3) > Not strictly a regression, but bug 482921 added a non-functional menu choice Bug 482921 didn't add the menu choice. It was there before. With old View Source, turning off highlights didn't turn off href linkification, so here's a patch that turns off the coloring but keeps the links (which remain colored as in the old impl).
Assignee: nobody → hsivonen
Status: NEW → ASSIGNED
Attachment #572400 - Flags: review?(bugs)
Marking dependent of bug 696585 so that a test case for this bug can be added once bug 696585 has been fixed.
Depends on: 696585
Comment on attachment 572400 [details] [diff] [review] Actually do something with mSyntaxHighlight Could you file a followup to change syntax highlighting so that reload isn't needed. (That would require some changes to viewsource.js and to the css. )
Attachment #572400 - Flags: review?(bugs) → review+
(In reply to Olli Pettay [:smaug] from comment #7) > Could you file a followup to change syntax highlighting so that reload > isn't needed. (That would require some changes to viewsource.js and to the > css. ) I filed bug 700382. I have doubts about offering the toggle in the UI at all. Thanks for the review. https://hg.mozilla.org/integration/mozilla-inbound/rev/9c1cdf04b728
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
You need to log in before you can comment on or make changes to this bug.