"Syntax Highlighting" button in view source-code menu doesn't work

RESOLVED FIXED in mozilla10

Status

()

Core
HTML: Parser
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: tchevalier, Assigned: hsivonen)

Tracking

({regression})

10 Branch
mozilla10
regression
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox10-)

Details

Attachments

(1 attachment)

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:10.0a1) Gecko/20111105 Firefox/10.0a1
Build ID: 20111105031111

Steps to reproduce:

Click on the "Syntax Highlighting" menu item on the view-source page.


Actual results:

The menu item is uncheck, but nothing happened to the code.


Expected results:

The code should be discolored.
OS: Windows 7 → All
See Also: → bug 482921
Confirming this on Linux with latest nightly.
Status: UNCONFIRMED → NEW
Ever confirmed: true
This either needs to be fixed before Tuesday.

Otherwise either the feature or menu choice needs to be removed after Firefox 10 goes to Aurora.
tracking-firefox10: --- → ?
Not strictly a regression, but bug 482921 added a non-functional menu choice which would seem to be a bad thing to have in a released product.
Blocks: 482921
Keywords: regression

Updated

6 years ago
Component: Developer Tools → HTML: Parser
Product: Firefox → Core
QA Contact: developer.tools → parser

Comment 4

6 years ago
Moved to Core:HTML Parser, which is where bug 482921 was filed.
Hardware: x86_64 → All
(Assignee)

Comment 5

6 years ago
Created attachment 572400 [details] [diff] [review]
Actually do something with mSyntaxHighlight

(In reply to Bill Gianopoulos from comment #3)
> Not strictly a regression, but bug 482921 added a non-functional menu choice

Bug 482921 didn't add the menu choice. It was there before.

With old View Source, turning off highlights didn't turn off href linkification, so here's a patch that turns off the coloring but keeps the links (which remain colored as in the old impl).
Assignee: nobody → hsivonen
Status: NEW → ASSIGNED
Attachment #572400 - Flags: review?(bugs)
(Assignee)

Comment 6

6 years ago
Marking dependent of bug 696585 so that a test case for this bug can be added once bug 696585 has been fixed.
Depends on: 696585

Comment 7

6 years ago
Comment on attachment 572400 [details] [diff] [review]
Actually do something with mSyntaxHighlight

Could you file a followup to change syntax highlighting so that reload
isn't needed. (That would require some changes to viewsource.js and to the
css. )
Attachment #572400 - Flags: review?(bugs) → review+
(Assignee)

Comment 8

6 years ago
(In reply to Olli Pettay [:smaug] from comment #7)
> Could you file a followup to change syntax highlighting so that reload
> isn't needed. (That would require some changes to viewsource.js and to the
> css. )

I filed bug 700382. I have doubts about offering the toggle in the UI at all.

Thanks for the review.
https://hg.mozilla.org/integration/mozilla-inbound/rev/9c1cdf04b728

Updated

6 years ago
Duplicate of this bug: 700315
https://hg.mozilla.org/mozilla-central/rev/9c1cdf04b728
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
Depends on: 702448

Updated

6 years ago
tracking-firefox10: ? → -
You need to log in before you can comment on or make changes to this bug.