700045 - Update splitter state instead of deck for BM Properties context menu option

Status: RESOLVED FIXED

(SeaMonkey :: Bookmarks & History, defect)

Description

[Jens Hatlak (:InvisibleSmiley)]

Attachment: patch [Checkin: comments 1 and 2]

From bug 674208 comment 11:

>+      var dd = document.getElementById("detailsDeck");
>+      if (dd)
>+        dd.collapsed = false;
Unfortunately you forgot to inform the splitter that you wanted to uncollapse the deck. So for instance in the Modern theme you notice that the uncollapse grippy still looks like an uncollapse grippy instead of a collapse grippy. And in any theme, clicking the grippy doesn't collapse the splitter, because it thinks it's collapsed and tries to uncollapse itself. Also the uncollapsed state doesn't persist. The correct code would be something like this:
  var dds = document.getElementById("detailsDeck-splitter");
  if (dds)
    dds.removeAttribute("state");
etc.


Like bug 696731, this should probably land on Aurora, too.

Comment 1

[Jens Hatlak (:InvisibleSmiley)]

Comment on attachment 572214 [details] [diff] [review]
patch [Checkin: comments 1 and 2]

http://hg.mozilla.org/comm-central/rev/1c71e12be421

Comment 2

[Jens Hatlak (:InvisibleSmiley)]

Comment on attachment 572214 [details] [diff] [review]
patch [Checkin: comments 1 and 2]

http://hg.mozilla.org/releases/comm-aurora/rev/832b2312c94e