Closed Bug 700045 Opened 9 years ago Closed 9 years ago

Update splitter state instead of deck for BM Properties context menu option

Categories

(SeaMonkey :: Bookmarks & History, defect)

defect
Not set
minor

Tracking

(seamonkey2.5 wontfix, seamonkey2.6 fixed, seamonkey2.7 fixed)

RESOLVED FIXED
seamonkey2.7
Tracking Status
seamonkey2.5 --- wontfix
seamonkey2.6 --- fixed
seamonkey2.7 --- fixed

People

(Reporter: InvisibleSmiley, Assigned: InvisibleSmiley)

References

Details

Attachments

(1 file)

From bug 674208 comment 11:

>+      var dd = document.getElementById("detailsDeck");
>+      if (dd)
>+        dd.collapsed = false;
Unfortunately you forgot to inform the splitter that you wanted to uncollapse the deck. So for instance in the Modern theme you notice that the uncollapse grippy still looks like an uncollapse grippy instead of a collapse grippy. And in any theme, clicking the grippy doesn't collapse the splitter, because it thinks it's collapsed and tries to uncollapse itself. Also the uncollapsed state doesn't persist. The correct code would be something like this:
  var dds = document.getElementById("detailsDeck-splitter");
  if (dds)
    dds.removeAttribute("state");
etc.


Like bug 696731, this should probably land on Aurora, too.
Attachment #572214 - Flags: review?(neil)
Attachment #572214 - Flags: approval-comm-aurora?
Attachment #572214 - Flags: review?(neil) → review+
Comment on attachment 572214 [details] [diff] [review]
patch [Checkin: comments 1 and 2]

http://hg.mozilla.org/comm-central/rev/1c71e12be421
Attachment #572214 - Attachment description: patch → patch [Checkin: comment 1]
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.7
Attachment #572214 - Flags: approval-comm-aurora? → approval-comm-aurora+
Comment on attachment 572214 [details] [diff] [review]
patch [Checkin: comments 1 and 2]

http://hg.mozilla.org/releases/comm-aurora/rev/832b2312c94e
Attachment #572214 - Attachment description: patch [Checkin: comment 1] → patch [Checkin: comments 1 and 2]
You need to log in before you can comment on or make changes to this bug.