Add mozapps/extensions/newaddon.css to Modern

RESOLVED FIXED in seamonkey2.9

Status

SeaMonkey
Themes
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: InvisibleSmiley, Assigned: InvisibleSmiley)

Tracking

({modern})

Trunk
seamonkey2.9
modern
Dependency tree / graph

SeaMonkey Tracking Flags

(seamonkey2.7+ fixed, seamonkey2.8 fixed, seamonkey2.9 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Bug 476430, which landed for FF 8 introduced a new CSS file to mozapps (newaddon.css). This file is only used by newaddon.xul, which is only supported starting with SM 2.7 (since bug 696598 landed). Modern needs a copy for the new functionality to work correctly with the alternate theme.

STR:
1. Download or create an XPI of an add-on that is compatible with the tested SM version and rename the XPI to <guid>.xpi (where <guid> is the em:id from install.rdf).
2. Choose an SM profile where the chosen add-on is not installed yet or make sure that's the case. Also make sure that profile has Modern as the active theme.
3. Copy the XPI into the extensions folder of the tested SM profile folder.
4. Start SM

Comment 1

6 years ago
Simpler STR: Type the following into the Location bar:
about:newaddon?id={1018e4d6-728f-4b20-ad56-37578a4de76b}
(assuming you have that extension installed.)

For some reason SeaMonkey just closes suddenly if you use the same GUID twice. (no crash report)
(In reply to Philip Chee from comment #1)
> Simpler STR: Type the following into the Location bar:
> about:newaddon?id={1018e4d6-728f-4b20-ad56-37578a4de76b}
> (assuming you have that extension installed.)
> 
> For some reason SeaMonkey just closes suddenly if you use the same GUID
> twice. (no crash report)

IIUC this is bug 684190, fixed-on-trunk 2011-10-07, see bug 684190 comment #5 (but there are followups to that bug, if you're using a newer build maybe one of them cought you).

Updated

6 years ago
Keywords: modern
We certainly should port this to modern, the specific coloring here is minimal. I hope we can make 2.7 for this, Jens any chance you can tackle this?
tracking-seamonkey2.7: ? → +
(Assignee)

Comment 4

6 years ago
(In reply to Philip Chee from comment #1)
> Simpler STR: Type the following into the Location bar:
> about:newaddon?id={1018e4d6-728f-4b20-ad56-37578a4de76b}
> (assuming you have that extension installed.)
> 
> For some reason SeaMonkey just closes suddenly if you use the same GUID
> twice. (no crash report)

If you hit Esc really quickly (and have some luck), you can get the page for any ID. Best to be tried with at least one other tab open. ;-)

I just found that the easiest way to get the page for real is to disable an add-on (I used Debug & QA, which I always disable first) and then try it, e.g.:

about:newaddon?id=debugQA@mozilla.org

Now that I'm past that I can try to fix this bug. :-)
(Assignee)

Comment 5

6 years ago
Created attachment 588778 [details] [diff] [review]
patch [Checkin: Comment 8]

Neil, Callek wants to still have this for our next beta, so maybe you can prioritize this? Thanks in advance.

Changes over winstripe version:
* ported general styling from about pages (about.css): colors and borders from html and body
* replaced Graytext by font-style:italic
* maybe more that I forgot...
Assignee: nobody → jh
Status: NEW → ASSIGNED
Attachment #588778 - Flags: review?(neil)

Comment 6

6 years ago
Comment on attachment 588778 [details] [diff] [review]
patch [Checkin: Comment 8]

>+@import url("chrome://global/skin/inContentUI.css");
We don't have this, so no need to import it. r=me with that fixed.
Attachment #588778 - Flags: review?(neil) → review+
(Assignee)

Comment 7

6 years ago
Comment on attachment 588778 [details] [diff] [review]
patch [Checkin: Comment 8]

Base bug 696598 already landed for 2.7, requesting approval accordingly for very safe patch.
Attachment #588778 - Flags: approval-comm-beta?
Attachment #588778 - Flags: approval-comm-aurora?

Updated

6 years ago
Attachment #588778 - Flags: approval-comm-beta?
Attachment #588778 - Flags: approval-comm-beta+
Attachment #588778 - Flags: approval-comm-aurora?
Attachment #588778 - Flags: approval-comm-aurora+
(Assignee)

Comment 8

6 years ago
Comment on attachment 588778 [details] [diff] [review]
patch [Checkin: Comment 8]

http://hg.mozilla.org/comm-central/rev/dedeed79d795
http://hg.mozilla.org/releases/comm-aurora/rev/34866c357587
http://hg.mozilla.org/releases/comm-beta/rev/b60c3297c75f
Attachment #588778 - Attachment description: patch → patch [Checkin: Comment 8]
(Assignee)

Updated

6 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
status-seamonkey2.7: --- → fixed
status-seamonkey2.8: --- → fixed
status-seamonkey2.9: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.9

Updated

5 years ago
Depends on: 751253
You need to log in before you can comment on or make changes to this bug.