Closed Bug 700201 Opened 8 years ago Closed 8 years ago

Addons that haven't been updated for an extremely long time should not be compatible by default

Categories

(Toolkit :: Add-ons Manager, defect)

defect
Not set

Tracking

()

VERIFIED FIXED
mozilla11
Tracking Status
firefox10 --- fixed

People

(Reporter: Unfocused, Assigned: Unfocused)

References

()

Details

(Keywords: dev-doc-complete, verified-aurora, Whiteboard: qa!)

Attachments

(1 file)

It is possible to obtain addons that haven't been updated since (for instance) Firefox 1.0. These are unlikely to work correctly (if at all) on modern versions of the application, and so shouldn't be compatible by default.

One solution is to have AMO blacklist these addons in the new <addon_compatibility> elements of the metadata ping. However, that only solves it for addons AMO has any data on.

A more generic solution is to have the application specify a minimum version that addons should be compatible by default with. This would't need to be changed very often.
Attached patch Patch v1Splinter Review
Attachment #572660 - Flags: review?(dtownsend)
Comment on attachment 572660 [details] [diff] [review]
Patch v1

Review of attachment 572660 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/app/profile/firefox.js
@@ +59,5 @@
>  pref("extensions.strictCompatibility", true);
>  
> +// Specifies a minimum maxVersion an addon needs to say it's compatible with
> +// for it to be compatible by default.
> +pref("extensions.minCompatibleAppVersion", "3.0");

We should have a newsgroup thread or something to decide what this should be.

::: toolkit/mozapps/extensions/XPIProvider.jsm
@@ +6975,5 @@
> +      else if (app.id == TOOLKIT_ID)
> +        minCompatVersion = XPIProvider.minCompatiblePlatformVersion;
> +
> +      if (minCompatVersion &&
> +          Services.vc.compare(minCompatVersion, app.maxVersion) > 0)

Shouldn't this compare against version rather than app.maxVersion?
Attachment #572660 - Flags: review?(dtownsend) → review-
Comment on attachment 572660 [details] [diff] [review]
Patch v1

Review of attachment 572660 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/mozapps/extensions/XPIProvider.jsm
@@ +6970,5 @@
> +
> +      // Extremely old extensions should not be compatible by default.
> +      let minCompatVersion;
> +      if (app.id == Services.appinfo.ID)
> +          minCompatVersion = XPIProvider.minCompatibleAppVersion;

Too much indentation
Attachment #572660 - Flags: review- → review+
(In reply to Dave Townsend (:Mossop) from comment #2)
> We should have a newsgroup thread or something to decide what this should be.

Indeed. Posted: https://groups.google.com/forum/#!topic/mozilla.dev.platform/Wkuc1W9TS9c
(Was also cross-posted to dev-apps-firefox.)
Toolkit 2.0 and Firefox 4.0 seem like reasonable defaults. Add-ons that say they were compatible with 3.5 or 3.6 and haven't been updated since then are unlikely to be in good shape.
(In reply to Alex Limi (:limi) — Firefox UX Team from comment #5)
> Toolkit 2.0 and Firefox 4.0 seem like reasonable defaults. Add-ons that say
> they were compatible with 3.5 or 3.6 and haven't been updated since then are
> unlikely to be in good shape.

Sounds good to me!
https://hg.mozilla.org/integration/fx-team/rev/9591426bab8e
Flags: in-testsuite+
Flags: in-litmus-
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → mozilla11
Comment on attachment 572660 [details] [diff] [review]
Patch v1

Tested, no string changes, an important part of the big addons-compatible-by-default push.
Attachment #572660 - Flags: approval-mozilla-aurora?
I should probably note that this feature is not currently enabled on Aurora (or Central, for that matter). Assuming we do decide to enable it for Fx10 (see bug 698653), it would be good to have this patch in now rather than later, so it can go through QA's scrutiny (and not suffer bitrot).
https://hg.mozilla.org/mozilla-central/rev/9591426bab8e
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Attachment #572660 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
This doesn't transplant to aurora cleanly, sad.
https://hg.mozilla.org/releases/mozilla-aurora/rev/6ff7fdaed43f
Whiteboard: [fixed-in-fx-team]
Target Milestone: mozilla11 → mozilla10
Target Milestone: mozilla10 → mozilla11
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:11.0a1) Gecko/20111127 Firefox/11.0a1
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:10.0a2) Gecko/20111127 Firefox/10.0a2
Mozilla/5.0 (Windows NT 5.1; rv:11.0a1) Gecko/20111127 Firefox/11.0a1
Mozilla/5.0 (Windows NT 5.1; rv:10.0a2) Gecko/20111127 Firefox/10.0a2
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:10.0a2) Gecko/20111127 Firefox/10.0a2
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:11.0a1) Gecko/20111128 Firefox/11.0a1
Mozilla/5.0 (X11; Linux i686; rv:11.0a1) Gecko/20111128 Firefox/11.0a1
Mozilla/5.0 (X11; Linux i686; rv:10.0a2) Gecko/20111128 Firefox/10.0a2

Verified Aurora and Nightly on Ubuntu 11.04, Mac OS 10.6, Windows XP, 7. Add-ons with max version smaller than 4.* are displayed as incompatible after the upgrade. Add-on with max version equal to 4.* is displayed as compatible after the upgrade.

1. Start Firefox 3.6.24 with clean profile.
2. Install following add-ons: 
https://addons.mozilla.org/en-US/firefox/addon/close-other-tabs/?src=ss
https://addons.mozilla.org/en-US/firefox/addon/go-classic/?src=ss
https://addons.mozilla.org/en-US/firefox/addon/replacetabs-extension/?src=ss
3. Upgrade to Firefox 11 (Firefox 10)
4. Open Add-ons manager

Replacetabs Extension is displayed as compatible (max version=4.*) as normal.
The other two extensions (max version smaller than 4.*) are displayed as incompatible after the upgrade.
Status: RESOLVED → VERIFIED
Keywords: verified-aurora
Whiteboard: qa!
Blocks: 706796
Version: unspecified → Trunk
You need to log in before you can comment on or make changes to this bug.