70031 - Smiley face not shown in mail

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Patty Mac]

Plaftorm: Windows and Linux only (2001-02-23-08-Mtrunk).

1. Launch Netscape 6.
2. Go to Tasks/Mail
3. Click on "New Message".
Notice when you type your message and then click on the smiley face, the smiley
face not shown.

Comment 1

[[e-mail] (gone - use [e-mail] instead)]

*** Bug 70032 has been marked as a duplicate of this bug. ***

Comment 2

[Boris Zbarsky [:bzbarsky]]

Same as bug 70034?

Comment 3

[Patty Mac]

I think bug 70031 and bug 70032 are slight different. 

Comment 4

[[e-mail] (gone - use [e-mail] instead)]

From bug 70032: 
Plaftorm: Windows and Linux only (2001-02-23-08-Mtrunk).

1. Launch Netscape 6.
2. Go to Tasks/Mail
3. Click on "New Message".
Notice when you type your message and then click on the smiley face, the smiley
face not shown.

Patty, how is that different from this bug?  Or did you mean this bug 70031 and 
70034 are different?  Bug 70031 and bug 70032 were filed within 1 minute of each 
other, have the same summary, same steps to reproduce, as well as the same 
platform.

Comment 5

[Patty Mac]

Stephen, Sorry that was my mistake. Yes, bug 70031 and bug 70032 are exactly
identical. Yes, I meant bug 70031 and bug 70034 are slightly different.
Thanks!

Comment 6

[R.K.Aa.]

Patty Mac: Are smilies still gone from mail on Windows?

Comment 7

[Aarne Männik]

Works for me with RC3 on Win98. Reporter, can you please confirm the bug still
exists for you with RC3 or more recent builds. If not can you please close the
report.

Comment 8

[Charles Manske]

This seems to be an old bug, but as of about 10/1/02, the smileys are busted
again. The cause is two-fold in the editor code:
1. With new command rewrite, the "doCommandParams" is now being called when a 
smiley is inserted, but that command wasn't implemented in ComposerCommands.js
2. The properer overlay style sheet to display smiley images is not being loaded
for Mail Composer.
I have the fix for these.

Comment 9

[Charles Manske]

Attachment: patch v1

This fix simplifies the editor's DocumentStateListener code, eliminating the 
separate MessageComposeDocumentStateListener. This will avoid errors by 
making it clear what code should be shared among all Composers and what should
only be executed by the Web Composer application.
The doCommandParams() method is implemented instead of "doCommand()", which is 

now deprecated. This fixes all smiley and style problems in Message Composer
as well as in IM (bugscape bugs 20282, 19942 and 19995)

Comment 10

[Suresh]

Comment on attachment 101831 [details] [diff] [review]
patch v1

r=suresh

Comment 11

[kinmoz]

Comment on attachment 101831 [details] [diff] [review]
patch v1

sr=[e-mail]

Comment 12

[Charles Manske]

Checked into 1.2beta trunk.

Comment 13

[Kathleen :Brade]

*** Bug 170072 has been marked as a duplicate of this bug. ***

Comment 14

[esther]

Using trunk build 20021029 on linux 20021028 on winxp and 20021025 on Mac OSX
this is fixed. Verified.