Closed Bug 700387 Opened 8 years ago Closed 8 years ago

Remove the Style Inspector breadcrumbs

Categories

(DevTools :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 10

People

(Reporter: msucan, Assigned: msucan)

References

Details

(Whiteboard: [styleinspector][fixed-in-fx-team])

Attachments

(1 file, 1 obsolete file)

The Style Inspector breadcrumbs duplicate the developer toolbar breadcrumbs. We should remove the SI ones.
Attached patch proposed patch (obsolete) — Splinter Review
Proposed patch. I hope I didn't miss anything.

Looking forward to the review. Thank you!
Assignee: nobody → mihai.sucan
Status: NEW → ASSIGNED
Attachment #572557 - Flags: review?(dcamp)
Rebased patch.
Attachment #572557 - Attachment is obsolete: true
Attachment #572557 - Flags: review?(dcamp)
Attachment #572564 - Flags: review?(dcamp)
Comment on attachment 572564 [details] [diff] [review]
[in-fx-team] rebased patch

This looks good.
Attachment #572564 - Flags: review?(dcamp) → review+
Should get a browser peer to sign off on theme changes though.
Comment on attachment 572564 [details] [diff] [review]
[in-fx-team] rebased patch

Pushed:
https://hg.mozilla.org/integration/fx-team/rev/d0da05c504a7
Attachment #572564 - Attachment description: rebased patch → [in-fx-team] rebased patch
Whiteboard: [styleinspector] → [styleinspector][fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/d0da05c504a7
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 10
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.