Closed Bug 700429 Opened 8 years ago Closed 8 years ago

mochitest-1 test_webgl_conformance_test_suite unexpected-passes are good passes on lion

Categories

(Core :: Canvas: WebGL, defect)

x86_64
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla13
Tracking Status
firefox11 --- fixed
firefox12 --- fixed

People

(Reporter: philor, Assigned: bjacob)

References

Details

(Whiteboard: [qa-])

Attachments

(2 files, 1 obsolete file)

I hid/am hiding all 10.7 tests, because I don't have time to deal with them today; the green stuff will need to be unhidden, perhaps on a less stressful day like tomorrow.

So far, hidden on:

mozilla-central/Firefox
mozilla-inbound
Fx-Team
Services-Central
mozilla-aurora
Try (where someone got to them before I remembered to)
Ionmonkey
The remaining mochitest-1 failures are two unexpected-passes in the WebGL mochitest:

46313 ERROR TEST-UNEXPECTED-PASS | /tests/content/canvas/test/webgl/test_webgl_conformance_test_suite.html | Test expected to fail, but passed: conformance/more/functions/uniformfBadArgs.html

46314 ERROR TEST-UNEXPECTED-PASS | /tests/content/canvas/test/webgl/test_webgl_conformance_test_suite.html | Test expected to fail, but passed: conformance/more/functions/uniformiBadArgs.html

Patch coming.
Attached patch pass mochitest-1 on lion slaves (obsolete) — Splinter Review
on tryserver:

https://tbpl.mozilla.org/?tree=Try&rev=cd828ff0c427

probably need to append ?noignore=1&jobname=lion to see the lion results.
Attachment #572827 - Flags: review?(jgilbert)
Unhid the green stuff on mozilla-central.

bjacob: since we're running them on Aurora (and I presume Beta as well), you and everyone else is going to need approval flags and status flags, so you'll want to file a separate bug for your patch. Bug numbers are cheap, and we need to hurry up and get to 800000 so we can have another contest ;)
Unhid on inbound, fx-team.
Unhid on Services-Central, Try, and Ionmonkey
Comment on attachment 572827 [details] [diff] [review]
pass mochitest-1 on lion slaves

Review of attachment 572827 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. Is there a wiki page somewhere that covers the different places that we specify which tests are expected to fail? We have the main three files, but we should also make it clear that we insert sub-platform-dependent ones in test_webgl_conformance_test_suite.html.

::: content/canvas/test/webgl/test_webgl_conformance_test_suite.html
@@ +327,5 @@
>      // code borrowed from browser/components/wintaskbar/test/browser_taskbar_preview.js
>      var is106orHigher = false;
>      netscape.security.PrivilegeManager.enablePrivilege("UniversalXPConnect");
> +    kDarwinVersion = parseFloat(Components.classes["@mozilla.org/system-info;1"]
> +                                              .getService(Components.interfaces.nsIPropertyBag2)

Looks like the indenting might have gotten messed up. (Looks wrong in splinter)
Attachment #572827 - Flags: review?(jgilbert) → review+
Yeah, please file new bugs for each set of tests.
Anything left to be done in this bug?
Or are we keeping it open until all 10.7 suites are green *and* unhidden?
The work to get all 10.7 tests green and unhidden is bug 700503.  This work is specifically for the unhidding of temporarily hidden already green tests.
OK cool.
FIXING for unhidding the already green tests.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Actually, lets morph this bug to track that patch that has been uploaded here and gotten review to fix mochitest-1.  Not sure which production or component to put this into.
Assignee: nobody → bjacob
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Summary: Unhide green 10.7 tests → mochitest-1 test_webgl_conformance_test_suite unexpected-passes are good passes on lion
Component: Release Engineering → Canvas: WebGL
Product: mozilla.org → Core
QA Contact: release → canvas.webgl
Version: other → Trunk
Benoit, philor pointed out that this patch never was landed. Want to de-rot it and try again?
https://tbpl.mozilla.org/?tree=Try&rev=4ca95d3464c5&noignore=1 - I discovered that *after* I'd already rewritten it (rather more ham-fistedly), and pointed it out *while* I was unrotting it :)

Once I see that I didn't break it, I'll probably throw in .push()ing the two tests that subsequent updates have added broken on 10.7 and push both.
Sorry for forgetting to land this, and thanks Phil for the work. So my understand is that you're handling this now.
Assignee: bjacob → philringnalda
Yup, though in your name ;)

https://hg.mozilla.org/integration/mozilla-inbound/rev/e271afc540a9
Assignee: philringnalda → bjacob
Target Milestone: --- → mozilla13
Attached patch as pushedSplinter Review
[Approval Request Comment]
User impact if declined: Another 11 weeks of totally wasted resources running mochitest-1 on 10.7 hidden, plus 11 more weeks of risking 10.7-only regressions in things tested in mochitest-1 because nobody looks at hidden tests.
Risk to taking this patch (and alternatives if risky): zero, test only, either the tests remain 'failing' (in this case, they are passing but marked failing) and hidden, or, as will happen (with one more patch), become green and visible.
String changes made by this patch: none.
Attachment #572827 - Attachment is obsolete: true
Attachment #594617 - Flags: approval-mozilla-aurora?
Attached patch for betaSplinter Review
The only difference is context, but whenever I decide I don't need to attach a patch, I wind up losing it.

[Approval Request Comment]
User impact if declined: Another 5 weeks of totally wasted resources running mochitest-1 on 10.7 hidden, plus 5 more weeks of risking 10.7-only regressions in things tested in mochitest-1 because nobody looks at hidden tests.
Risk to taking this patch (and alternatives if risky): none, test only
String changes made by this patch: none
Attachment #594631 - Flags: approval-mozilla-beta?
https://hg.mozilla.org/mozilla-central/rev/e271afc540a9
Status: REOPENED → RESOLVED
Closed: 8 years ago8 years ago
Resolution: --- → FIXED
Comment on attachment 594617 [details] [diff] [review]
as pushed

[Triage Comment]
Test fix - approved for Aurora.
Attachment #594617 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Attachment #594631 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Depends on: 724455
Whiteboard: [qa-]
No longer blocks: 700503
You need to log in before you can comment on or make changes to this bug.