Closed
Bug 700535
Opened 13 years ago
Closed 13 years ago
Need to be able to pref off account provisioner
Categories
(Thunderbird :: Mail Window Front End, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 10.0
People
(Reporter: mconley, Assigned: mconley)
References
Details
Attachments
(1 file, 1 obsolete file)
4.38 KB,
patch
|
bwinton
:
review+
|
Details | Diff | Splinter Review |
It's great that we're landing this feature, but it'd be a good idea to be able to pref it off in case something goes sour during it's stabilization in EarlyBird.
Assignee | ||
Updated•13 years ago
|
Assignee: nobody → mconley
Blocks: 686347
tracking-thunderbird10:
--- → ?
Target Milestone: --- → Thunderbird 11.0
Assignee | ||
Comment 1•13 years ago
|
||
Did I find all of the contact points between TB and the account provisioner? Let me know if I missed something.
Attachment #572845 -
Flags: review?(bwinton)
Comment 2•13 years ago
|
||
Comment on attachment 572845 [details] [diff] [review] Patch v1 Review of attachment 572845 [details] [diff] [review]: ----------------------------------------------------------------- Looks good, but won't preffing it off cause all our tests to fail?
Attachment #572845 -
Flags: review?(bwinton) → review-
Assignee | ||
Comment 3•13 years ago
|
||
Ah, good point - I'll make sure that the provisioner tests force enabled to be true. Just a sec...
Assignee | ||
Comment 4•13 years ago
|
||
Thanks for the review on Patch v1! I've added some code to record the value of mail.provider.enabled, and then force it to be true for the Account Provisioner tests. At teardown, the test then puts the original mail.provider.enabled value back.
Attachment #572845 -
Attachment is obsolete: true
Attachment #572888 -
Flags: review?(bwinton)
Comment 5•13 years ago
|
||
Comment on attachment 572888 [details] [diff] [review] Patch v2 Review of attachment 572888 [details] [diff] [review]: ----------------------------------------------------------------- Looks good by inspection, so r=me if the tests pass. Thanks, Blake.
Attachment #572888 -
Flags: review?(bwinton) → review+
Assignee | ||
Comment 6•13 years ago
|
||
The Account Provisioner tests pass for me, so I've pushed. Committed as: http://hg.mozilla.org/comm-central/rev/79673156553b
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Updated•13 years ago
|
Comment 7•13 years ago
|
||
Comment on attachment 572888 [details] [diff] [review] Patch v2 I think we should transplant this onto aurora as well - as that's where it initially landed, and enterprises will probably want this.
Attachment #572888 -
Flags: approval-comm-aurora+
Assignee | ||
Comment 8•13 years ago
|
||
This patch was able to sneak in before the Aurora merge over, so it's already a part of comm-aurora - see: http://hg.mozilla.org/releases/comm-aurora/rev/79673156553b
tracking-thunderbird10:
+ → ---
Target Milestone: Thunderbird 11.0 → Thunderbird 10.0
Comment 9•13 years ago
|
||
Comment on attachment 572888 [details] [diff] [review] Patch v2 ok, thanks
Attachment #572888 -
Flags: approval-comm-aurora+
You need to log in
before you can comment on or make changes to this bug.
Description
•