Closed Bug 700535 Opened 10 years ago Closed 10 years ago

Need to be able to pref off account provisioner

Categories

(Thunderbird :: Mail Window Front End, defect)

x86
All
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 10.0

People

(Reporter: mconley, Assigned: mconley)

References

Details

Attachments

(1 file, 1 obsolete file)

It's great that we're landing this feature, but it'd be a good idea to be able to pref it off in case something goes sour during it's stabilization in EarlyBird.
Assignee: nobody → mconley
Blocks: 686347
Target Milestone: --- → Thunderbird 11.0
Attached patch Patch v1 (obsolete) — Splinter Review
Did I find all of the contact points between TB and the account provisioner?  Let me know if I missed something.
Attachment #572845 - Flags: review?(bwinton)
Comment on attachment 572845 [details] [diff] [review]
Patch v1

Review of attachment 572845 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, but won't preffing it off cause all our tests to fail?
Attachment #572845 - Flags: review?(bwinton) → review-
Ah, good point - I'll make sure that the provisioner tests force enabled to be true.  Just a sec...
Attached patch Patch v2Splinter Review
Thanks for the review on Patch v1!

I've added some code to record the value of mail.provider.enabled, and then force it to be true for the Account Provisioner tests.  At teardown, the test then puts the original mail.provider.enabled value back.
Attachment #572845 - Attachment is obsolete: true
Attachment #572888 - Flags: review?(bwinton)
Comment on attachment 572888 [details] [diff] [review]
Patch v2

Review of attachment 572888 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good by inspection, so r=me if the tests pass.

Thanks,
Blake.
Attachment #572888 - Flags: review?(bwinton) → review+
The Account Provisioner tests pass for me, so I've pushed.

Committed as:  http://hg.mozilla.org/comm-central/rev/79673156553b
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Comment on attachment 572888 [details] [diff] [review]
Patch v2

I think we should transplant this onto aurora as well - as that's where it initially landed, and enterprises will probably want this.
Attachment #572888 - Flags: approval-comm-aurora+
This patch was able to sneak in before the Aurora merge over, so it's already a part of comm-aurora - see:  http://hg.mozilla.org/releases/comm-aurora/rev/79673156553b
Target Milestone: Thunderbird 11.0 → Thunderbird 10.0
Comment on attachment 572888 [details] [diff] [review]
Patch v2

ok, thanks
Attachment #572888 - Flags: approval-comm-aurora+
You need to log in before you can comment on or make changes to this bug.