700544 - IndexedDB: Start a transaction when created, not when first request is placed

Status: RESOLVED FIXED

(Core :: Storage: IndexedDB, defect)

Description

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

I.e. given the following code:

var trans1 = db.transaction("foo", READ_WRITE);
var trans2 = db.transaction("foo", READ_WRITE);
trans2.put("2", "key");
trans1.put("1", "key");

The objectStore should after the two transactions commit contain the value "2" since trans2 should run after trans1.

Comment 1

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Attachment: Patch

I slipped some cleanup in TransactionThreadPool in here too.

Comment 2

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 574376 [details] [diff] [review]
Patch

Review of attachment 574376 [details] [diff] [review]:
-----------------------------------------------------------------

Ha, you tricked me.

::: dom/indexedDB/IDBTransaction.cpp
@@ +99,5 @@
> +}
> +
> +NS_IMPL_QUERY_INTERFACE1(StartTransactionRunnable, nsIRunnable)
> +
> +StartTransactionRunnable kDummyRunnable;

Nit: Let's call this gStartTransactionRunnable.

Comment 3

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

(In reply to ben turner [:bent] from comment #2)
> Comment on attachment 574376 [details] [diff] [review] [diff] [details] [review]
> Patch
> 
> Review of attachment 574376 [details] [diff] [review] [diff] [details] [review]:
> -----------------------------------------------------------------
> 
> Ha, you tricked me.

Indeed.

> ::: dom/indexedDB/IDBTransaction.cpp
> @@ +99,5 @@
> > +}
> > +
> > +NS_IMPL_QUERY_INTERFACE1(StartTransactionRunnable, nsIRunnable)
> > +
> > +StartTransactionRunnable kDummyRunnable;
> 
> Nit: Let's call this gStartTransactionRunnable.

Done.

Comment 4

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

https://hg.mozilla.org/mozilla-central/rev/ca8665b874d8

Comment 5

[Chris Mills [:cmills]]

Killing some old dev-doc-needed bugs ;-)

I've now documented this, adding a note in both the Transaction interface page, and the release notes for Firefox 11...

https://developer.mozilla.org/en-US/docs/Web/API/IDBTransaction
https://developer.mozilla.org/en-US/Firefox/Releases/11#IndexedDB