700657 - Permanent orange: TEST-UNEXPECTED-FAIL | test-instrument-setup.js | test_mail_account_setup

Status: RESOLVED FIXED

(Thunderbird :: Testing Infrastructure, defect)

Description

[Mike Conley (:mconley) (:⚙️)]

This just started showing up after Account Provisioner landed (bug 686347):

SUMMARY-UNEXPECTED-FAIL | test-instrument-setup.js | test_mail_account_setup
  EXCEPTION: Timed out waiting for window open!
    at: utils.js line 429
       TimeoutError("Timed out waiting for window open!") utils.js 429
       waitFor((function () this.monitorizeOpen()),"Timed out waiting for window open!",10000,100,[object Object]) utils.js 467
       WindowWatcher_waitForWindowOpen("mail:autoconfig") test-window-helpers.js 290
       wait_for_existing_window("mail:autoconfig") test-window-helpers.js 552
       test_mail_account_setup() test-instrument-setup.js 82
            frame.js 554
            frame.js 623
            frame.js 666
            frame.js 494
            frame.js 672
            server.js 182
            server.js 186

My working theory is that the Account Provisioner window is coming up instead of the Exiting Account dialog.  I'll know more in a few minutes.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Patch v1

So there were two bugs here:

The first was that the test was expecting the existing account dialog, but instead encountered the account provisioner window.  That's been fixed.

Next, some emailWizard code was using if (object.blah) to determine if exists as a key in object.  Instead, we need to use

"blah" in object

The test now passes for me reliably.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Committed as http://hg.mozilla.org/comm-central/rev/b429f50bac8c