[traceback] High error rate from search excerpts

VERIFIED FIXED in 2011-11-15

Status

support.mozilla.org
Search
VERIFIED FIXED
7 years ago
7 years ago

People

(Reporter: jsocol, Assigned: willkg)

Tracking

unspecified
2011-11-15

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

7 years ago
We're getting a high error rate (several per minute, likely to increase as users wake up) from search excerpts in production. (Traceback below.) The old search code wrapped BuildExcerpts in a try/except socket.error. 

We'd like to continue to log these errors in statsd but it may not be worth fixing Sphinx at this point.


Traceback (most recent call last):

  File "/data/www/support.mozilla.org/kitsune/vendor/src/django/django/core/handlers/base.py", line 111, in get_response
    response = callback(request, *callback_args, **callback_kwargs)

  File "/data/www/support.mozilla.org/kitsune/vendor/src/django-mobility/mobility/decorators.py", line 23, in wrapper
    return f(request, *args, **kw)

  File "/data/www/support.mozilla.org/kitsune/apps/search/views.py", line 315, in search
    clean_excerpt(question_s.excerpt(doc)[0]))

  File "/data/www/support.mozilla.org/kitsune/vendor/src/oedipus/oedipus/__init__.py", line 352, in excerpt
    list(docs), self.meta.index, self._query, options)

  File "/data/www/support.mozilla.org/kitsune/vendor/src/sphinxapi/sphinxapi/__init__.py", line 744, in BuildExcerpts
    sock = self._Connect()

  File "/data/www/support.mozilla.org/kitsune/vendor/src/sphinxapi/sphinxapi/__init__.py", line 208, in _Connect
    v = unpack('>L', sock.recv(4))

timeout: timed out
This adds 'search.excerpt.timeout' and 'search.excerpt.socketerror' statsd things and also fixes the problem where we weren't handling socket.timeout and socket.error exceptions when excerpting.

97041af6e4846999c45c11d5af68ea5a2d81a179 in master.

66ba9bdf67942f834bca216c377c7eecbb2a755e in next.
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
(Reporter)

Comment 2

7 years ago
STR: Look through search results, particularly of questions, until you find an empty summary. That means we caught an error and moved along.
Verified found questions with blank summaries searching on 'help with plugins', no other errors were generated.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.