Socorro - adjust signature generation for new Java stack field in json

RESOLVED FIXED in 2.4.1

Status

Socorro
Backend
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: lars, Unassigned)

Tracking

Trunk
2.4.1
x86_64
Linux
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [qa-])

Attachments

(1 attachment)

(Reporter)

Description

7 years ago
The current processor signature generation code expects Java stack info to be in the AppNotes field.  Soon, that data will move to its own field within the json. When this change lands in Breakpad, Socorro must change too.
(Reporter)

Updated

7 years ago
Depends on: 701002
(Assignee)

Updated

7 years ago
Component: Socorro → General
Product: Webtools → Socorro
This field needs to be searchable as well.  hence blocks 718820

Comment 2

7 years ago
(In reply to Naoki Hirata :nhirata from comment #1)
> This field needs to be searchable as well.  hence blocks 718820

Not sure what you mean with "searchable". For one thing, signatures need to be generated from it, sure, that's this bug. And signatures can be searched well anyhow.
For the other, I think in search, the new field should be treated similarly to frames further down the stack than the signature. Once we know more about what's coming implementation-wise here (before that we can't act on anything), i.e. once bug 701002 comes along, we might need a couple dependencies for different details like search, listing in our exported CSVs, etc. - but those only make sense once we know what the client side will be doing and what the field will be called in Socorro.
Assignee: nobody → cpeterson
Assignee: cpeterson → nobody
(Reporter)

Updated

7 years ago
Assignee: nobody → lars

Comment 3

7 years ago
Commit pushed to https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/897d4ddb955b11b0a7f3893b2d3f89780e8e654b
Merge pull request #295 from twobraids/Bug701390-JavaSig

add new Java signature algorithm
(Reporter)

Comment 4

7 years ago
Created attachment 591234 [details]
a Fennec crash that deserves a Java signature

this now merged.  I've attached a Java crash pair that demonstrates the correctness of this patch.  

The signature generated by this crash should be:

  "java.lang.RuntimeException: CPETERSON BUG701002 TEST at org.mozilla.gecko.GeckoApp.doReload(GeckoApp.java)"

single spaces between all words, no line feeds.
(Reporter)

Updated

7 years ago
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED

Updated

7 years ago
Blocks: 721078

Updated

7 years ago
Assignee: lars → nobody
Component: General → Backend
QA Contact: socorro → backend
Target Milestone: --- → 2.4.1

Updated

7 years ago
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.