Closed Bug 701504 Opened 8 years ago Closed 7 years ago

"ASSERTION: Can't find frame in lines!" with -moz-column, -moz-isolate, rtl

Categories

(Core :: Layout, defect, critical)

defect
Not set
critical

Tracking

()

RESOLVED FIXED
mozilla23

People

(Reporter: jruderman, Assigned: mats)

References

(Blocks 1 open bug)

Details

(Keywords: assertion, crash, testcase)

Attachments

(4 files)

###!!! ASSERTION: Can't find frame in lines!: 'hasNext', file layout/base/nsBidiPresUtils.cpp, line 377

###!!! ABORT: comparing iterators over different lists: 'mListLink == aOther.mListLink', file layout/generic/nsLineBox.h, line 722

Similar symptoms to bug 695861, which smontagu fixed last week.
Attached file stack traces
Now fails with a different abort:

###!!! ASSERTION: Can't find frame in lines!: 'hasNext', file layout/base/nsBidiPresUtils.cpp, line 317

###!!! ABORT: running past end: 'mCurrent != mListLink', file nsLineBox.h, line 681
Attached file frame dump
We're calling AdvanceLineIteratorToFrame with aPrevFrame that's in a different
block than the line iterator container.
Assignee: nobody → matspal
Attached patch fix+testSplinter Review
Trivial fix, but note also how this avoids calling bpd.GetSubParagraph()
which allocates it if it didn't exist.  AFAICT, that's unnecessary.
Attachment #733314 - Flags: review?(smontagu)
OS: Mac OS X → All
Hardware: x86_64 → All
Comment on attachment 733314 [details] [diff] [review]
fix+test

Review of attachment 733314 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #733314 - Flags: review?(smontagu) → review+
https://hg.mozilla.org/mozilla-central/rev/a827177c136e
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in before you can comment on or make changes to this bug.