701870 - Make sure that setting a preference, then quiting, results in the preference being saved

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P3)

Description

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

1. go to the preferences and set to about:blank
2. hit back
3. explicitly quit the application by hitting the menu and selecting quit
4. relaunch

Expected: about:home
Actual: the last page that you are on.

Note: even if you force quit the application using settings, and relaunch you still show the last page you are on.

testbuild

Comment 1

[Doug Turner (:dougt)]

bugs related to our Quit feature.

Comment 2

[Doug Turner (:dougt)]

We use to rely on onXreExit() delaying System.exit().  Things may have changed using the window.close() approach, but not sure.  We should verify that setting a preference, then quiting, results in the preference being saved.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

We could wait for Gecko to quit ("quit-application") and send a "Gecko:Quit" to Java, and then System.exit(0)

Comment 4

[Steffen Wilberg]

You can't set the homepage right now, it fails with
E/GeckoPreferences(  717): invalid preference given to setPreference()

about:home is hardcoded. That's bug 696950.
It's a pity because about:home is completely broken. Bug 701380 will reimplement it in Java.

If you were seeing the last used page, that was the screenshot, which has been disabled a few days ago.

So I'd dupe this to bug 696950, but comment 2 mentions another bug.
Changing the summary accordingly.

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Should be fixed now that "Quit" is fixed

Comment 6

[Aaron Train [:aaronmt]]

Samsung Galaxy SII (Android 2.3.4)
20111202040206
http://hg.mozilla.org/projects/birch/rev/e2a54aafac18

Comment 7

[Erin Lancaster [:elan]]

So, the home page preference is still not being saved between quits...tested with 12/06 build.

Comment 8

[Steffen Wilberg]

That's bug 696950 - about:home is hardcoded.
Ask :bnicholson to unbitrot his patch...