Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Bookmark icon remains selected when navigating to another page that is not bookmarked

VERIFIED FIXED

Status

()

Firefox for Android
General
P3
normal
VERIFIED FIXED
6 years ago
a year ago

People

(Reporter: Mohamed Dabbagh, Assigned: lucasr)

Tracking

unspecified
ARM
Android
Points:
---

Firefox Tracking Flags

(firefox11 fixed, fennec11+)

Details

(Whiteboard: [testday-20111111])

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

6 years ago
Using a Samsung Galaxy Tab 10.1 and the build from http://bit.ly/vRtbCF.

When the user bookmarks a page, if they navigate to another page that is not part of their bookmarks, the bookmark icon remains selected.

1. Launch Fennec - Build above
2. Navigate to a site by clicking on the tab
3. Click on the menu to open it - In the top right (4 dashed lines)
4. Click on it again to close it
5. Click on the bookmark icon beside the menu button (a star) 
6. Navigate to another site

Actual Results:
The bookmark icon remains selected even though the newly visited page is not bookmarked.

Expected Results:
The bookmark icon become unselected again if the page is not already bookmarked.
(Reporter)

Updated

6 years ago
Whiteboard: [testday-20111111]

Comment 1

6 years ago
Using latest birch nightly:  20111114

Using a Samsung Galaxy tab 10.1 It seems that successive sights remain bookmarked.

Comment 2

6 years ago
lucas, can we listen for some event.
Assignee: nobody → lucasr.at.mozilla
Priority: -- → P3
(Assignee)

Comment 3

6 years ago
Bookmarking (adding/removing) seems to be generally broken in ICS/Honeycomb (which includes the Galaxy Tab) due to schema changes on the underlying database. Investigating how to best fix this and bug 698828. It's important to have a good understanding of those issues as part of implementing local Firefox dbs for bookmarks/history (bug 704490).
(Assignee)

Comment 4

6 years ago
Created attachment 579092 [details] [diff] [review]
Fix query to check bookmark URL in Honeycomb/ICS

Built on top of changes in bug 704490.
Attachment #579092 - Flags: review?(blassey.bugs)
(Assignee)

Updated

6 years ago
Depends on: 704490
Comment on attachment 579092 [details] [diff] [review]
Fix query to check bookmark URL in Honeycomb/ICS

Review of attachment 579092 [details] [diff] [review]:
-----------------------------------------------------------------

clearing the review until the pixie dust is figured out
Attachment #579092 - Flags: review?(blassey.bugs)
(Assignee)

Comment 6

6 years ago
Created attachment 580878 [details] [diff] [review]
Fix query to check bookmark URL in Honeycomb/ICS
Attachment #579092 - Attachment is obsolete: true
Attachment #580878 - Flags: review?(blassey.bugs)
Attachment #580878 - Flags: review?(blassey.bugs) → review+
(Assignee)

Comment 7

6 years ago
Pushed: http://hg.mozilla.org/mozilla-central/rev/00e184077825
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Samsung Galaxy Tab 10.1 (Android 3.1)
20111213061518
http://hg.mozilla.org/mozilla-central/rev/e79b3396889c

Looking to also verify on ICS.
Status: RESOLVED → VERIFIED
tracking-fennec: --- → 11+
status-firefox11: --- → fixed
You need to log in before you can comment on or make changes to this bug.