701913 - Bookmark icon remains selected when navigating to another page that is not bookmarked

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P3)

Description

[Mohamed Dabbagh]

Using a Samsung Galaxy Tab 10.1 and the build from http://bit.ly/vRtbCF.

When the user bookmarks a page, if they navigate to another page that is not part of their bookmarks, the bookmark icon remains selected.

1. Launch Fennec - Build above
2. Navigate to a site by clicking on the tab
3. Click on the menu to open it - In the top right (4 dashed lines)
4. Click on it again to close it
5. Click on the bookmark icon beside the menu button (a star) 
6. Navigate to another site

Actual Results:
The bookmark icon remains selected even though the newly visited page is not bookmarked.

Expected Results:
The bookmark icon become unselected again if the page is not already bookmarked.

Comment 1

[John Hammink]

Using latest birch nightly:  20111114

Using a Samsung Galaxy tab 10.1 It seems that successive sights remain bookmarked.

Comment 2

[Doug Turner (:dougt)]

lucas, can we listen for some event.

Comment 3

[Lucas Rocha (:lucasr)]

Bookmarking (adding/removing) seems to be generally broken in ICS/Honeycomb (which includes the Galaxy Tab) due to schema changes on the underlying database. Investigating how to best fix this and bug 698828. It's important to have a good understanding of those issues as part of implementing local Firefox dbs for bookmarks/history (bug 704490).

Comment 4

[Lucas Rocha (:lucasr)]

Attachment: Fix query to check bookmark URL in Honeycomb/ICS

Built on top of changes in bug 704490.

Comment 5

[Brad Lassey [:blassey] (use needinfo?)]

Comment on attachment 579092 [details] [diff] [review]
Fix query to check bookmark URL in Honeycomb/ICS

Review of attachment 579092 [details] [diff] [review]:
-----------------------------------------------------------------

clearing the review until the pixie dust is figured out

Comment 6

[Lucas Rocha (:lucasr)]

Attachment: Fix query to check bookmark URL in Honeycomb/ICS

Comment 7

[Lucas Rocha (:lucasr)]

Pushed: http://hg.mozilla.org/mozilla-central/rev/00e184077825

Comment 8

[Aaron Train [:aaronmt]]

Samsung Galaxy Tab 10.1 (Android 3.1)
20111213061518
http://hg.mozilla.org/mozilla-central/rev/e79b3396889c

Looking to also verify on ICS.