Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Adding bookmarks doesn't work (Honeycomb, maybe ICS?)

VERIFIED FIXED

Status

()

Firefox for Android
General
P3
normal
VERIFIED FIXED
6 years ago
a year ago

People

(Reporter: kats, Assigned: lucasr)

Tracking

unspecified
ARM
Android
Points:
---

Firefox Tracking Flags

(firefox11 fixed, fennec11+)

Details

Attachments

(3 attachments, 1 obsolete attachment)

1. Go to a page that is not in the bookmarks
2. Bookmark the page by hitting the "star" icon (you may need to tap the menu to make the star icon appear - see bug 698748)
3. Note that the toast notifications indicates the page has been bookmarked, and the star icon is updated to match.
4. Bring up the awesome bar bookmarks list and look for the page you just bookmarked; it is not there. Expected result: the page should be there.
5. Close the awesome bar and reload the page you were on. Note that the "star" icon again indicates an un-bookmarked page. Expected result: the star icon should indicate the page is bookmarked.

The attachments show a dump of the Browser.BOOKMARKS_URI table as obtained via this line of code:
android.database.DatabaseUtils.dumpCursor(getContentResolver().query(android.provider.Browser.BOOKMARKS_URI, null, null, null, null));

The dump from the "before" attachment was taken after I (1) cleared the history and (2) went to google.com, which redirected me to google.ca. The "after" dump was obtained after hitting the star icon at that point.

However, I observed that if I go to the page, THEN clear the history, and THEN star the page, bookmarking works as expected.
Created attachment 571077 [details]
Dump of BOOKMARKS_URI before starring page
Created attachment 571079 [details]
Dump of BOOKMARKS_URI after starring page

Updated

6 years ago
Priority: -- → P3
Confirming that on my Samsung Galaxy SII (Android 2.3.4), bookmarks added under native Fennec, are not added in the default "Internet" browser under TouchWiz 4.0.
My mistake, this looks like a bug in the TouchWiz 4.0 browser; or just an implementation detail. After adding a bookmark in native Fennec successfully, you can access the bookmark by querying it in the browser; albeit for some reason the bookmark is not displayed in their "Thumbnail View" (where I had first looked).

Updated

6 years ago
Duplicate of this bug: 701925
(Assignee)

Comment 6

6 years ago
Taking as I'm working on bug 701913 which is directly related.
Assignee: nobody → lucasr.at.mozilla
(Assignee)

Comment 7

6 years ago
Created attachment 579094 [details] [diff] [review]
Fix add bookmark operation in Honeycomb/ICS

Build on top of changes in bug 704490.
Attachment #579094 - Flags: review?(blassey.bugs)
(Assignee)

Updated

6 years ago
Depends on: 704490
Comment on attachment 579094 [details] [diff] [review]
Fix add bookmark operation in Honeycomb/ICS

Review of attachment 579094 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/db/AndroidBrowserDB.java
@@ +183,5 @@
> +        values.put(Browser.BookmarkColumns.BOOKMARK, "1");
> +        values.put(Browser.BookmarkColumns.TITLE, title);
> +        values.put(Browser.BookmarkColumns.URL, uri);
> +
> +        cr.insert(Browser.BOOKMARKS_URI, values);

why don't you have to check that the value exists post 11?
(Assignee)

Comment 9

6 years ago
(In reply to Brad Lassey [:blassey] from comment #8)
> Comment on attachment 579094 [details] [diff] [review]
> Fix add bookmark operation in Honeycomb/ICS
> 
> Review of attachment 579094 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: mobile/android/base/db/AndroidBrowserDB.java
> @@ +183,5 @@
> > +        values.put(Browser.BookmarkColumns.BOOKMARK, "1");
> > +        values.put(Browser.BookmarkColumns.TITLE, title);
> > +        values.put(Browser.BookmarkColumns.URL, uri);
> > +
> > +        cr.insert(Browser.BOOKMARKS_URI, values);
> 
> why don't you have to check that the value exists post 11?

Misread Android's source code a bit. Submitting the correct patch now.
(Assignee)

Comment 10

6 years ago
Created attachment 580875 [details] [diff] [review]
Fix add bookmark operation in Honeycomb/ICS
Attachment #579094 - Attachment is obsolete: true
Attachment #579094 - Flags: review?(blassey.bugs)
Attachment #580875 - Flags: review?(blassey.bugs)
Attachment #580875 - Flags: review?(blassey.bugs) → review+
(Assignee)

Comment 11

6 years ago
Pushed: http://hg.mozilla.org/mozilla-central/rev/71a7af64da86
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Samsung Galaxy Tab 10.1 (Android 3.1)
20111213061518
http://hg.mozilla.org/mozilla-central/rev/e79b3396889c

Looking to also verify on ICS.
Status: RESOLVED → VERIFIED
tracking-fennec: --- → 11+
status-firefox11: --- → fixed
You need to log in before you can comment on or make changes to this bug.