Scratchpad russian codepage

RESOLVED FIXED in Firefox 12



Developer Tools
6 years ago
6 years ago


(Reporter: Andrew, Assigned: dchan)



9 Branch
Firefox 12
Windows 7

Firefox Tracking Flags

(Not tracked)



(4 attachments, 2 obsolete attachments)



6 years ago
Created attachment 574177 [details]

User Agent: Mozilla/5.0 (Windows NT 6.1; rv:9.0) Gecko/20100101 Firefox/9.0
Build ID: 20111109112850

Steps to reproduce:

Scratchpad - File - Open File - naroddisknocaptcha@script.user.js (utf-8) - see screen-shot (76867.png)

If i write in clear Scratchpad - all normal.

Comment 1

6 years ago
Created attachment 574178 [details]


6 years ago
Version: 9 Branch → unspecified


6 years ago
Version: unspecified → 9 Branch
Attachment #574178 - Attachment mime type: application/octet-stream → text/javascript
Thanks for the bug report!

This looks like it works fine in Firefox 10+ with Orion enabled.

Presumably this will be a problem in Firefoxes 8-10 with the text-based source editor in place.
Ever confirmed: true

Comment 3

6 years ago
Created attachment 574629 [details]
orion 11

In 8, 9, 10, 11 - same too.
Strange. I'm unable to reproduce this with your attached text on my machine in OS X.

Can anyone with a Windows machine try this out?
Keywords: qawanted

Comment 5

6 years ago
Not all the characters are displaying for me either.

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:10.0a1) Gecko/20111108 Firefox/10.0a1 ID:20111108031146

OS X 10.6.8

Copying and pasting works fine. The script file also displays properly in Dashcode


6 years ago
Assignee: nobody → dchan+bugzilla

Comment 6

6 years ago
Created attachment 574738 [details] [diff] [review]
convert input to UTF-8

I copied the code from exportToFile and it appears to work. We may be able to remove the manual conversion once bug 655658 lands.
Attachment #574738 - Flags: feedback?

Comment 7

6 years ago
Created attachment 574743 [details] [diff] [review]
convert input to UTF-8 v2

We probably want to pass the unicode version of the content to the callback. Stupid mistake
Attachment #574738 - Attachment is obsolete: true
Attachment #574738 - Flags: feedback?
Attachment #574743 - Flags: feedback?

Comment 8

6 years ago
Will be implemented by the wrap of long lines in scratchpad (style editor and other) and file://, ftp://, http://, https://, etc protocols (in default or checkbox in settings)?
Comment on attachment 574743 [details] [diff] [review]
convert input to UTF-8 v2

this looks like it should do the trick.
Attachment #574743 - Flags: feedback? → feedback+

Comment 10

6 years ago
Hmmm, looking at the documentation again. I'm not sure if converter.Finish() needs to be called when converting to unicode. It seems to work fine without it. Does anyone have more experience with nsIScriptableUnicodeConverter?

Comment 11

6 years ago
Created attachment 581829 [details] [diff] [review]
convert input to UTF-8 v3

Remove the Finish() call since it is only needed for ConvertFromUnicode() and not ConvertToUnicode()

I need help landing the patch on m-c
Attachment #574743 - Attachment is obsolete: true
Attachment #581829 - Flags: review?(rcampbell)
Duplicate of this bug: 694967
Comment on attachment 581829 [details] [diff] [review]
convert input to UTF-8 v3

I thought I reviewed this already. Sorry for the delay.
Attachment #581829 - Flags: review?(rcampbell) → review+
Whiteboard: [land-in-fx-team]
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 12
Duplicate of this bug: 716371
You need to log in before you can comment on or make changes to this bug.