Closed Bug 702144 Opened 8 years ago Closed 8 years ago

Scratchpad russian codepage

Categories

(DevTools :: General, defect)

9 Branch
x86
Windows 7
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 12

People

(Reporter: northtech, Assigned: dchanm+bugzilla)

References

Details

(Keywords: qawanted)

Attachments

(4 files, 2 obsolete files)

Attached image 76867.png
User Agent: Mozilla/5.0 (Windows NT 6.1; rv:9.0) Gecko/20100101 Firefox/9.0
Build ID: 20111109112850

Steps to reproduce:

Scratchpad - File - Open File - naroddisknocaptcha@script.user.js (utf-8) - see screen-shot (76867.png)


If i write in clear Scratchpad - all normal.
Version: 9 Branch → unspecified
Version: unspecified → 9 Branch
Attachment #574178 - Attachment mime type: application/octet-stream → text/javascript
Thanks for the bug report!

This looks like it works fine in Firefox 10+ with Orion enabled.

Presumably this will be a problem in Firefoxes 8-10 with the text-based source editor in place.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Attached image orion 11
In 8, 9, 10, 11 - same too.
Strange. I'm unable to reproduce this with your attached text on my machine in OS X.

Can anyone with a Windows machine try this out?
Keywords: qawanted
Not all the characters are displaying for me either.

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:10.0a1) Gecko/20111108 Firefox/10.0a1 ID:20111108031146

OS X 10.6.8

Copying and pasting works fine. The script file also displays properly in Dashcode
Assignee: nobody → dchan+bugzilla
Attached patch convert input to UTF-8 (obsolete) — Splinter Review
I copied the code from exportToFile and it appears to work. We may be able to remove the manual conversion once bug 655658 lands.
Attachment #574738 - Flags: feedback?
Attached patch convert input to UTF-8 v2 (obsolete) — Splinter Review
We probably want to pass the unicode version of the content to the callback. Stupid mistake
Attachment #574738 - Attachment is obsolete: true
Attachment #574738 - Flags: feedback?
Attachment #574743 - Flags: feedback?
Will be implemented by the wrap of long lines in scratchpad (style editor and other) and file://, ftp://, http://, https://, etc protocols (in default or checkbox in settings)?
Comment on attachment 574743 [details] [diff] [review]
convert input to UTF-8 v2

this looks like it should do the trick.
Attachment #574743 - Flags: feedback? → feedback+
Hmmm, looking at the documentation again. I'm not sure if converter.Finish() needs to be called when converting to unicode. It seems to work fine without it. Does anyone have more experience with nsIScriptableUnicodeConverter?
Remove the Finish() call since it is only needed for ConvertFromUnicode() and not ConvertToUnicode()

I need help landing the patch on m-c
Attachment #574743 - Attachment is obsolete: true
Attachment #581829 - Flags: review?(rcampbell)
Comment on attachment 581829 [details] [diff] [review]
convert input to UTF-8 v3

I thought I reviewed this already. Sorry for the delay.
Attachment #581829 - Flags: review?(rcampbell) → review+
Whiteboard: [land-in-fx-team]
https://hg.mozilla.org/integration/fx-team/rev/805facc7eb21
Status: NEW → ASSIGNED
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/805facc7eb21
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 12
Duplicate of this bug: 716371
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.