Closed
Bug 702281
Opened 13 years ago
Closed 12 years ago
Telemetry prompt on mobile should be tri-state
Categories
(Firefox for Android Graveyard :: General, defect, P5)
Tracking
(Not tracked)
VERIFIED
FIXED
Firefox 13
People
(Reporter: lmandel, Assigned: mfinkle)
References
Details
Attachments
(1 file)
3.01 KB,
patch
|
bnicholson
:
review+
|
Details | Diff | Splinter Review |
We should track the difference between clicking "no" and "x" (dismissing the door hanger) in telemetry prompt/advertising on mobile. The difference between "no" and "x" is that a user who explicitly clicks "no" should not be re-prompted while a user who dismisses the door hanger is a candidate for re-prompting (as they haven't made an explicit choice). Note that this functionality was recently introduced on desktop (bug 697860).
Comment 1•13 years ago
|
||
One can't dismiss the door-hanger, unless you're referring to closing the Nightly Start Page. -- Tested via: 20111114081755 http://hg.mozilla.org/projects/birch/rev/772155060499
Reporter | ||
Comment 2•13 years ago
|
||
(In reply to Aaron Train [:aaronmt] from comment #1) > One can't dismiss the door-hanger, unless you're referring to closing the > Nightly Start Page. You're right. This behaviour will change after bug 700434 is fixed.
Depends on: 700434
Updated•13 years ago
|
Flags: in-litmus?(fennec)
Whiteboard: [QA+]
Updated•13 years ago
|
Priority: -- → P5
Assignee | ||
Comment 3•12 years ago
|
||
This patch kinda follows what desktop did: * It changes toolkit.telemetry.enabled from a bool pref to an int (please don't this in the future) * enabled = false by default * It enables if the user taps "Yes" * It rejects if the user taps "No", but it does not set enabled since it defaults to false * If either button is tapped we set the prompted pref to the rev number * If neither button is pressed (user uses BACK), no prefs are set and we will reprompt
Assignee: nobody → mark.finkle
Attachment #595815 -
Flags: review?(bnicholson)
Updated•12 years ago
|
Attachment #595815 -
Flags: review?(bnicholson) → review+
Assignee | ||
Comment 4•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/c09af9f27313
Comment 5•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/c09af9f27313
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 13
Comment 6•12 years ago
|
||
Test case added in litmus under: BFT - General: https://litmus.mozilla.org/show_test.cgi?id=50500
Comment 7•12 years ago
|
||
Nightly 13.0a1 (2012-03-05) Device: Samsung Nexus S - Android 2.3.6 Verified fixed: when telemetry prompt is displayed if user: - dismisses the by tapping outside the prompt or device back button, then the prompt is displayed again when restarting, or visiting the page again. - selects "yes": telemetry is enabled, toolkit.telemetry.enabled=true - select "no": telemetry is disabled, toolkit.telemetry.enabled=false
Status: RESOLVED → VERIFIED
Flags: in-litmus?(fennec) → in-litmus+
Whiteboard: [QA+]
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•