702281 - Telemetry prompt on mobile should be tri-state

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P5)

Description

[Lawrence Mandel [:lmandel] (use needinfo)]

We should track the difference between clicking "no" and "x" (dismissing the door hanger) in telemetry prompt/advertising on mobile. The difference between "no" and "x" is that a user who explicitly clicks "no" should not be re-prompted while a user who dismisses the door hanger is a candidate for re-prompting (as they haven't made an explicit choice). 

Note that this functionality was recently introduced on desktop (bug 697860).

Comment 1

[Aaron Train [:aaronmt]]

One can't dismiss the door-hanger, unless you're referring to closing the Nightly Start Page.

--
Tested via:
20111114081755
http://hg.mozilla.org/projects/birch/rev/772155060499

Comment 2

[Lawrence Mandel [:lmandel] (use needinfo)]

(In reply to Aaron Train [:aaronmt] from comment #1)
> One can't dismiss the door-hanger, unless you're referring to closing the
> Nightly Start Page.

You're right. This behaviour will change after bug 700434 is fixed.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

This patch kinda follows what desktop did:
* It changes toolkit.telemetry.enabled from a bool pref to an int (please don't this in the future)
* enabled = false by default
* It enables if the user taps "Yes"
* It rejects if the user taps "No", but it does not set enabled since it defaults to false
* If either button is tapped we set the prompted pref to the rev number
* If neither button is pressed (user uses BACK), no prefs are set and we will reprompt

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c09af9f27313

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/c09af9f27313

Comment 6

[Camelia Urian]

Test case added in litmus under: BFT - General:
https://litmus.mozilla.org/show_test.cgi?id=50500

Comment 7

[Camelia Urian]

Nightly 13.0a1 (2012-03-05)
Device: Samsung Nexus S - Android 2.3.6

Verified fixed: when telemetry prompt is displayed if user:
- dismisses the by tapping outside the prompt or device back button, then the prompt is displayed again when restarting, or visiting the page again.
- selects "yes": telemetry is enabled, toolkit.telemetry.enabled=true
- select "no": telemetry is disabled, toolkit.telemetry.enabled=false