702688 - Search key on awesomebar screen should dismiss it

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Lucas Rocha (:lucasr)]

In terms of using search key, I think the strictly correct behaviour would be:
1. While on primary browser UI, if you press Search key, it will take you to AwesomeBar screen (already done).
2. While on AwesomeBar screen, if you press Search key, it will take you back to primary browser UI.

See bug 697178 for discussion.

Comment 1

[Lucas Rocha (:lucasr)]

Attachment: Search key on awesomebar screen should dismiss it

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 574863 [details] [diff] [review]
Search key on awesomebar screen should dismiss it

>     @Override
>     public boolean onKeyDown(int keyCode, KeyEvent event) {

>+            keyCode == KeyEvent.KEYCODE_MENU ||
>+            keyCode == KeyEvent.KEYCODE_SEARCH ||

You are checking for the MENU here in case it is treated as a search?

Comment 3

[Lucas Rocha (:lucasr)]

(In reply to Mark Finkle (:mfinkle) from comment #2)
> Comment on attachment 574863 [details] [diff] [review] [diff] [details] [review]
> Search key on awesomebar screen should dismiss it
> 
> >     @Override
> >     public boolean onKeyDown(int keyCode, KeyEvent event) {
> 
> >+            keyCode == KeyEvent.KEYCODE_MENU ||
> >+            keyCode == KeyEvent.KEYCODE_SEARCH ||
> 
> You are checking for the MENU here in case it is treated as a search?

Yes. If I don't do that, the search key (long press on menu key in Galaxy S) is never triggered. This shouldn't affect other devices in anyway.

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Lucas Rocha (:lucasr) from comment #3)

> Yes. If I don't do that, the search key (long press on menu key in Galaxy S)
> is never triggered. This shouldn't affect other devices in anyway.

OK. Sounds good.

Comment 5

[Lucas Rocha (:lucasr)]

Pushed: http://hg.mozilla.org/projects/birch/rev/8f2c51a1f148

Comment 6

[Catalin Suciu [:csuciu]]

Verified fixed on:
Mozilla/5.0 (Android;Linux armv7l;rv:11.0a1)Gecko/20111117 Firefox/11.0a1 Fennec/11.0a1
Device: Galaxy S
OS: Android 2.2