nsXULWindow::PersistPositionAndSize is 6% of every window activate

RESOLVED FIXED in mozilla0.9.2

Status

()

P2
normal
RESOLVED FIXED
18 years ago
17 years ago

People

(Reporter: mikepinkerton, Assigned: danm.moz)

Tracking

({perf})

Trunk
mozilla0.9.2
PowerPC
Mac System 9.x
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: wanted for 0.9.1/Mojo beta)

Attachments

(1 attachment)

(Reporter)

Description

18 years ago
when profiling window activate, i found that 6% of the time to process the 
activate event is spent peristing size and position of the window. do we really 
need to do it on _every_ activate event?
(Reporter)

Updated

18 years ago
Blocks: 48274

Comment 1

18 years ago
Why don't we do this at window close time?

Comment 2

18 years ago
Doing it at close is not what users expect or want, but we should be able to 
avoid a write to disk every time. ->moz1.0/perf
Keywords: perf
Target Milestone: --- → mozilla1.0

Comment 3

18 years ago
This is one of the worst responsiveness bugs we have, and is a dependency of one
of the most-voted-for nscatfood bugs.  Any chance we could make progress on it
for 0.9.1?
Priority: -- → P2
Whiteboard: wanted for 0.9.1/Mojo beta

Comment 4

18 years ago
This didn't show up on my Windows window activate profiling at all.  Could this 
really be mac only?  pink, how'd you test window activation?

Comment 5

18 years ago
Created attachment 33295 [details]
top F+D times (% of focus)
(Assignee)

Updated

18 years ago
Status: NEW → ASSIGNED
Target Milestone: mozilla1.0 → mozilla0.9.1
(Reporter)

Comment 6

18 years ago
i used the MW profiler, testing the time spent processing the activate event.

Updated

18 years ago
Target Milestone: mozilla0.9.1 → mozilla0.9.2
(Assignee)

Comment 7

18 years ago
See patch and time comparisons in bug 79060
(Assignee)

Comment 8

18 years ago
Patch from bug 79060 is in (0.9.2). So now PersistPositionAndSize should (if 
times on the Mac and on Windows are relatively similar) be about 1% of window 
activation, unless some rude person has already sped up the rest of that process.
Status: ASSIGNED → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → FIXED
(Assignee)

Comment 9

17 years ago
Note that this optimization has been 95% backed out. See bug 86955 and bug 89740.
You need to log in before you can comment on or make changes to this bug.