70283 - nsXULWindow::PersistPositionAndSize is 6% of every window activate

Status: RESOLVED FIXED

(Core :: XUL, defect, P2)

Description

[Mike Pinkerton (not reading bugmail)]

when profiling window activate, i found that 6% of the time to process the 
activate event is spent peristing size and position of the window. do we really 
need to do it on _every_ activate event?

Comment 1

[Simon Fraser [no longer active]]

Why don't we do this at window close time?

Comment 2

[Peter Trudelle]

Doing it at close is not what users expect or want, but we should be able to 
avoid a write to disk every time. ->moz1.0/perf

Comment 3

[Peter Trudelle]

This is one of the worst responsiveness bugs we have, and is a dependency of one
of the most-voted-for nscatfood bugs.  Any chance we could make progress on it
for 0.9.1?

Comment 4

[Blake Ross]

This didn't show up on my Windows window activate profiling at all.  Could this 
really be mac only?  pink, how'd you test window activation?

Comment 5

[Blake Ross]

Attachment: top F+D times (% of focus)

Comment 6

[Mike Pinkerton (not reading bugmail)]

i used the MW profiler, testing the time spent processing the activate event.

Comment 7

[Dan M]

See patch and time comparisons in bug 79060

Comment 8

[Dan M]

Patch from bug 79060 is in (0.9.2). So now PersistPositionAndSize should (if 
times on the Mac and on Windows are relatively similar) be about 1% of window 
activation, unless some rude person has already sped up the rest of that process.

Comment 9

[Dan M]

Note that this optimization has been 95% backed out. See bug 86955 and bug 89740.