Expose pref for "optimal" text size in Fennec UI

VERIFIED FIXED

Status

()

Firefox for Android
General
P3
normal
VERIFIED FIXED
6 years ago
11 months ago

People

(Reporter: madhava, Assigned: mbrubeck)

Tracking

unspecified
All
Android
Points:
---
Dependency tree / graph
Bug Flags:
in-moztrap +

Firefox Tracking Flags

(firefox11 fixed, fennec11+)

Details

(Whiteboard: readability, [QA+])

Attachments

(2 attachments)

(Reporter)

Description

6 years ago
The new readability code relies on the concept of an "optimal" reading text size. In practice, there will not be such a size for all people. We should find a good default, but we should also allow some adjustment.

I think we'll want to express this not as a number or even a continuous slider, but instead as a few discrete steps of sizes, like the Kindle does.
(Reporter)

Updated

6 years ago
Priority: -- → P3
(Assignee)

Comment 1

6 years ago
Bug 627842 adds (hidden) prefs for this, so all we need to do is decide what default and alternate values to provide for Fennec, and what to call them.
Assignee: nobody → mbrubeck
Depends on: 627842
OS: Mac OS X → Android
Hardware: x86 → All
Summary: add pref for "optimal" text size → Expose pref for "optimal" text size in Fennec UI
(Reporter)

Comment 2

6 years ago
Here's the Android Kindle app size picker http://blog.laptopmag.com/wpress/wp-content/uploads/2010/06/KindleApp-readingthemes.png
(Reporter)

Comment 3

6 years ago
So, we could do something like this:

http://farm7.static.flickr.com/6100/6351067829_599d0ac4cf_b.jpg

In Flickr: http://www.flickr.com/photos/madhava_work/6351067829/
(Reporter)

Comment 4

6 years ago
Adding mnovak for some guidance on what our firefoxy whimsical sample text could be. Something from the manifest? "The quick orange fox jumped over the..." Is there something we're already using elsewhere?

Comment 5

6 years ago
Hey guys. I think this is very cool. I love the idea of "the quick orange fox," but I also think there's an opportunity to inject our brand message into it. The below incorporates both, using some new copy that was recently created by our agency. Keep in mind that depending on the size of the text selected, users would see a different amount of copy (ideally at the largest size it would end after "expectations"). I post this here to start a discussion on what people think does and/or doesn't work. Happy to make changes. Also adding Slater so he can weigh in.


The quick orange fox jumps over your expectations with more customization, more privacy and more control. As a non-profit, we're free to innovate on your behalf without any pressure to compromise. That means a better experience for you and a brighter future for the Web.
(Reporter)

Comment 6

6 years ago
Oh man. Yes please.

"Jumps over your expectations" is killer.

Comment 7

6 years ago
w00t! Glad you like it. One tweak, though, based on some other changes we recently made:

The quick orange fox jumps over your expectations with more speed, more flexibility and more security. As a non-profit, we're free to innovate on your behalf without any pressure to compromise. That means a better experience for you and a brighter future for the Web.

Comment 8

6 years ago
Awesome/splendid.

Comment 9

6 years ago
Splawesome?
(Reporter)

Updated

6 years ago
Whiteboard: readability
Here is a link to the wiki entry I made on the topic which should provide enough info to fix the bug.

https://wiki.mozilla.org/Fennec/NativeUI/UserExperience/Readability
(Assignee)

Updated

6 years ago
Blocks: 698593
(Assignee)

Comment 11

6 years ago
Created attachment 581854 [details] [diff] [review]
basic UI

As a first step, this adds a simple list-based UI with four choices: small (6pt), medium (8pt), large (10pt), and extra large (14pt).

I will build the more complete UX sketched out above as a follow-up, but I thought it would be good to get something simple in right away.
Attachment #581854 - Flags: review?(mark.finkle)
Comment on attachment 581854 [details] [diff] [review]
basic UI

You removed "permissions.default.image" from the getter in browser.js but not in the setter. You could remove it too.
Attachment #581854 - Flags: review?(mark.finkle) → review+
(Assignee)

Comment 13

6 years ago
Basic pref UI landed: https://hg.mozilla.org/integration/mozilla-inbound/rev/cf70852dfbd9

I'll open a follow-up bug for implementing the full UX design.
Status: NEW → ASSIGNED
https://hg.mozilla.org/mozilla-central/rev/cf70852dfbd9
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED

Updated

6 years ago
Flags: in-litmus?(fennec)
Whiteboard: readability → readability, [QA+]

Updated

6 years ago
Depends on: 711418
Created attachment 582278 [details]
Mobile Website @ Small Size

What are the font size measurements for the different sizes (sm, med, lg, xlg)?

Also if you visit a mobile site the text inflation is quite large at the small setting, its closer to what I would expect on the medium or large setting.
(Assignee)

Comment 16

6 years ago
(In reply to Patryk Adamczyk from comment #15)
> What are the font size measurements for the different sizes (sm, med, lg,
> xlg)?

6pt, 8pt, 10pt, and 14pt.  (See comment 11 for reference.)

> Also if you visit a mobile site the text inflation is quite large at the
> small setting, its closer to what I would expect on the medium or large
> setting.

Note that text inflation will make text *larger* when needed, but it will never make text smaller.  So if a site already has large text, the text will stay large regardless of the inflation settings.   Can you set the value to 0 in about:config to compare the text size with inflation disabled?  If it looks like inflation is resulting in too-large text on a specific site, please file a bug.
(Assignee)

Updated

6 years ago
No longer depends on: 711418
tracking-fennec: --- → 11+
status-firefox11: --- → fixed
(Assignee)

Updated

6 years ago
Blocks: 715179
Feature covered by the Readability test suite in MozTrap. The tests can be found here: https://moztrap.mozilla.org/manage/cases/?filter-suite=74
Flags: in-litmus?(fennec) → in-moztrap+
For Firefox Mobile 16.0b1 the simple list of selectable values has been implemented. For Aurora 17.0a2 2012-09-04 and Nightly 18.0a1 2012-09-04 the new UI has been added similar to the Kindle interface.

Verified on:
Samsung Galaxy R (Android 2.3.4)
Samsung Galaxy Tab 2 7.0 Android (4.0.4)
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.