Always dispatch mozfullscreenchange to owning document

RESOLVED FIXED in Firefox 10

Status

()

Core
DOM: Core & HTML
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: cpearce, Assigned: cpearce)

Tracking

10 Branch
mozilla10
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox10 fixed, firefox11 fixed)

Details

(Whiteboard: [qa?])

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
The W3 draft spec has changed so that the "fullscreenchange" event is now always dispatched to the document, rather than to the full-screen element upon entering and the document upon exiting from full-screen. We think this is sensible since your listener needs to be on the document to catch both cases anyway, so we should make this change in Firefox 10 so we get this right from the start.

Updated

6 years ago
tracking-firefox10: --- → ?
(Assignee)

Comment 1

6 years ago
Created attachment 575370 [details] [diff] [review]
Patch: Always dispatch mozfullscreenchange to owning document

Always dispatch mozfullscreenchange to owning document to match recent changes to W3 draft spec.
Attachment #575370 - Flags: review?(bzbarsky)
Comment on attachment 575370 [details] [diff] [review]
Patch: Always dispatch mozfullscreenchange to owning document

r=me
Attachment #575370 - Flags: review?(bzbarsky) → review+
(Assignee)

Comment 3

6 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/244a16163240
status-firefox10: --- → affected
status-firefox11: --- → affected

Comment 4

6 years ago
https://hg.mozilla.org/mozilla-central/rev/244a16163240
Status: NEW → RESOLVED
Last Resolved: 6 years ago
status-firefox11: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla11
Could you please update the mozfullscreenchange handler in browser.js? Specifically this part:
     let targetDoc = event.target.ownerDocument ? event.target.ownerDocument : event.target;
(Assignee)

Updated

6 years ago
Depends on: 704011
(Assignee)

Comment 6

6 years ago
Comment on attachment 575370 [details] [diff] [review]
Patch: Always dispatch mozfullscreenchange to owning document

It would be good if we can land this on Aurora since it changes the target of the "you've entered/left full-screen" event, and we'd like to ship the full-screen API in Firefox 10 as close to its final state as possible.
Attachment #575370 - Flags: approval-mozilla-aurora?

Updated

6 years ago
Attachment #575370 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
(Assignee)

Comment 7

6 years ago
https://hg.mozilla.org/releases/mozilla-aurora/rev/97436b3527a9
status-firefox10: affected → fixed
tracking-firefox10: ? → ---
Target Milestone: mozilla11 → mozilla10
Is this something QA can verify?
Whiteboard: [qa?]
(In reply to Anthony Hughes, Mozilla QA (irc: ashughes) from comment #8)
> Is this something QA can verify?

bump
You need to log in before you can comment on or make changes to this bug.