Last Comment Bug 704011 - mozfullscreenchange event handler assumes target is an element not a document
: mozfullscreenchange event handler assumes target is an element not a document
Status: RESOLVED FIXED
:
Product: Firefox
Classification: Client Software
Component: General (show other bugs)
: 11 Branch
: All All
: -- normal (vote)
: Firefox 11
Assigned To: Chris Pearce (:cpearce)
:
:
Mentors:
Depends on:
Blocks: 703079
  Show dependency treegraph
 
Reported: 2011-11-20 13:22 PST by Chris Pearce (:cpearce)
Modified: 2012-02-01 13:59 PST (History)
0 users
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (1.61 KB, patch)
2011-11-20 13:38 PST, Chris Pearce (:cpearce)
dao+bmo: review+
Details | Diff | Splinter Review

Description Chris Pearce (:cpearce) 2011-11-20 13:22:02 PST
Bug 703079 changed the mozfullscreenchange event target is always the owning document, rather than the element upon entering full-screen and document on exiting.

The mozfullscreenchange handler in browser.js needs to be updated to reflect that, though the existing code still works as is.
Comment 1 Chris Pearce (:cpearce) 2011-11-20 13:38:45 PST
Created attachment 575771 [details] [diff] [review]
Patch
Comment 2 Dão Gottwald [:dao] 2011-11-20 23:33:29 PST
Comment on attachment 575771 [details] [diff] [review]
Patch

thanks!
Comment 4 Ed Morley [:emorley] 2011-11-21 19:07:15 PST
https://hg.mozilla.org/mozilla-central/rev/816d3aca13c4

Note You need to log in before you can comment on or make changes to this bug.