703210 - tooltip is not shown if stopPropagation() of mousemove event is called

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch

I have no idea for writing tests of tooltip...

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 576859 [details] [diff] [review]
Patch

The test could be a chrome test using event listener popupshowing
or some such event.

Comment 3

[Neil Deakin]

>-        evtTarget = do_QueryInterface(doc);
>-        evtTarget->AddEventListener(NS_LITERAL_STRING("DOMMouseScroll"), 
>+        // Probably, we should listen to untrusted events for hiding tooltips
>+        // on content since tooltips might disturb something of web
>+        // applications.  If we don't specify the aWantsUntrusted of
>+        // AddSystemEventListener(), the event taget set it to TRUE if the
>+        // target is in content.

Not sure about this, but 'taget' should be 'target'.

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Hmm, I cannot make the new test. Looks like that tooltip's showing event is fired on the XUL document which has the showing tooltip. I don't know if this is an intentional behavior. I think, at least for tests, we should be able to know the tooltip state from tests. I'll file a bug for it.

https://hg.mozilla.org/integration/mozilla-inbound/rev/b2a4048facc0

Comment 5

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/b2a4048facc0

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: test

Okay, I succeeded to write the test.

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 577897 [details] [diff] [review]
test

Make sure to push this to try before landing.

Comment 8

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

of course, done.
https://tbpl.mozilla.org/?tree=Try&usebuildbot=1&rev=78e5abd73ab1
https://tbpl.mozilla.org/?tree=Try&usebuildbot=1&rev=f013b5718b97

Comment 9

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

inbound:
https://hg.mozilla.org/integration/mozilla-inbound/rev/50e07a58ee89

Comment 10

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/50e07a58ee89

Comment 11

[Arthur Iakab [arthur_iakab]]

Attachment: Bug - 1565339 disable browser_Bug 703210.js on Windows r=#intermittent-reviewers