Closed Bug 703235 Opened 12 years ago Closed 12 years ago

Remove ConsoleStorage

Categories

(DevTools :: Console, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 11

People

(Reporter: sonny, Assigned: sonny)

References

Details

Attachments

(1 file)

bug 588871 "Remove ConsoleStorage methods used for log message storage" take into account that consolestorage is still used for webconsole filters config.

bug 62233 (patch waiting for review) makes consolestorage obsolete for filters config

So I propose to remove the ConsoleStorage code from HUDService.jsm
Assignee: nobody → sonny.piers
Depends on: 588871, 622303
Sounds good to me, but please wait for me to review bug 622303. :)
I already wrote the patch but I'll wait for the review to upload it.
(In reply to Sonny Piers [:sonny] from comment #2)
> I already wrote the patch but I'll wait for the review to upload it.

Ah, then you can upload it!
Status: NEW → ASSIGNED
Attached patch patch v1Splinter Review
Attachment #575679 - Flags: review?(mihai.sucan)
No longer depends on: 588871
Attachment #575679 - Flags: review?(mihai.sucan)
Comment on attachment 575679 [details] [diff] [review]
patch v1

I cancelled the review because I taught I did something wrong but finally everything looks ok.

Sorry.
Attachment #575679 - Flags: review?(mihai.sucan)
Comment on attachment 575679 [details] [diff] [review]
patch v1

Review of attachment 575679 [details] [diff] [review]:
-----------------------------------------------------------------

This is a definite r+! THANK YOU very much Sonny! This is code clean up I wanted a long time ago! /me doing joy dance!

Great work Sonny!
Attachment #575679 - Flags: review?(mihai.sucan) → review+
Component: Developer Tools → Developer Tools: Console
QA Contact: developer.tools → developer.tools.console
Whiteboard: [land-in-fx-team]
https://hg.mozilla.org/integration/fx-team/rev/3af9c38e8a52
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/3af9c38e8a52
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 11
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.