Closed
Bug 703235
Opened 14 years ago
Closed 14 years ago
Remove ConsoleStorage
Categories
(DevTools :: Console, defect)
DevTools
Console
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 11
People
(Reporter: sonny, Assigned: sonny)
References
Details
Attachments
(1 file)
|
25.00 KB,
patch
|
msucan
:
review+
|
Details | Diff | Splinter Review |
bug 588871 "Remove ConsoleStorage methods used for log message storage" take into account that consolestorage is still used for webconsole filters config.
bug 62233 (patch waiting for review) makes consolestorage obsolete for filters config
So I propose to remove the ConsoleStorage code from HUDService.jsm
|
Assignee | |
Updated•14 years ago
|
Assignee: nobody → sonny.piers
|
|
Assignee | |
Updated•14 years ago
|
|
||
Comment 1•14 years ago
|
||
Sounds good to me, but please wait for me to review bug 622303. :)
|
|
Assignee | |
Comment 2•14 years ago
|
||
I already wrote the patch but I'll wait for the review to upload it.
|
|
||
Comment 3•14 years ago
|
||
(In reply to Sonny Piers [:sonny] from comment #2)
> I already wrote the patch but I'll wait for the review to upload it.
Ah, then you can upload it!
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 4•14 years ago
|
||
Attachment #575679 -
Flags: review?(mihai.sucan)
|
|
Assignee | |
Updated•14 years ago
|
Blocks: consolecleanup
|
|
Assignee | |
Updated•14 years ago
|
Attachment #575679 -
Flags: review?(mihai.sucan)
|
|
Assignee | |
Comment 5•14 years ago
|
||
Comment on attachment 575679 [details] [diff] [review]
patch v1
I cancelled the review because I taught I did something wrong but finally everything looks ok.
Sorry.
Attachment #575679 -
Flags: review?(mihai.sucan)
|
|
||
Comment 6•14 years ago
|
||
Comment on attachment 575679 [details] [diff] [review]
patch v1
Review of attachment 575679 [details] [diff] [review]:
-----------------------------------------------------------------
This is a definite r+! THANK YOU very much Sonny! This is code clean up I wanted a long time ago! /me doing joy dance!
Great work Sonny!
Attachment #575679 -
Flags: review?(mihai.sucan) → review+
|
|
||
Updated•14 years ago
|
Component: Developer Tools → Developer Tools: Console
QA Contact: developer.tools → developer.tools.console
Whiteboard: [land-in-fx-team]
|
|
||
Comment 8•14 years ago
|
||
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
|
|
||
Comment 9•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 11
|
||
Updated•7 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•