Last Comment Bug 703235 - Remove ConsoleStorage
: Remove ConsoleStorage
Status: RESOLVED FIXED
:
Product: Firefox
Classification: Client Software
Component: Developer Tools: Console (show other bugs)
: Trunk
: All All
: -- normal (vote)
: Firefox 11
Assigned To: Sonny Piers [:sonny]
:
Mentors:
: 588871 (view as bug list)
Depends on: 622303
Blocks: consolecleanup
  Show dependency treegraph
 
Reported: 2011-11-17 03:27 PST by Sonny Piers [:sonny]
Modified: 2011-11-29 22:07 PST (History)
4 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch v1 (25.00 KB, patch)
2011-11-19 09:15 PST, Sonny Piers [:sonny]
mihai.sucan: review+
Details | Diff | Splinter Review

Description Sonny Piers [:sonny] 2011-11-17 03:27:50 PST
bug 588871 "Remove ConsoleStorage methods used for log message storage" take into account that consolestorage is still used for webconsole filters config.

bug 62233 (patch waiting for review) makes consolestorage obsolete for filters config

So I propose to remove the ConsoleStorage code from HUDService.jsm
Comment 1 Mihai Sucan [:msucan] 2011-11-17 03:36:31 PST
Sounds good to me, but please wait for me to review bug 622303. :)
Comment 2 Sonny Piers [:sonny] 2011-11-17 04:51:11 PST
I already wrote the patch but I'll wait for the review to upload it.
Comment 3 Mihai Sucan [:msucan] 2011-11-17 09:43:19 PST
(In reply to Sonny Piers [:sonny] from comment #2)
> I already wrote the patch but I'll wait for the review to upload it.

Ah, then you can upload it!
Comment 4 Sonny Piers [:sonny] 2011-11-19 09:15:04 PST
Created attachment 575679 [details] [diff] [review]
patch v1
Comment 5 Sonny Piers [:sonny] 2011-11-19 13:53:57 PST
Comment on attachment 575679 [details] [diff] [review]
patch v1

I cancelled the review because I taught I did something wrong but finally everything looks ok.

Sorry.
Comment 6 Mihai Sucan [:msucan] 2011-11-20 02:30:21 PST
Comment on attachment 575679 [details] [diff] [review]
patch v1

Review of attachment 575679 [details] [diff] [review]:
-----------------------------------------------------------------

This is a definite r+! THANK YOU very much Sonny! This is code clean up I wanted a long time ago! /me doing joy dance!

Great work Sonny!
Comment 7 Sonny Piers [:sonny] 2011-11-21 13:18:26 PST
*** Bug 588871 has been marked as a duplicate of this bug. ***
Comment 8 Rob Campbell [:rc] (:robcee) 2011-11-29 11:14:00 PST
https://hg.mozilla.org/integration/fx-team/rev/3af9c38e8a52
Comment 9 Tim Taubert [:ttaubert] 2011-11-29 22:07:30 PST
https://hg.mozilla.org/mozilla-central/rev/3af9c38e8a52

Note You need to log in before you can comment on or make changes to this bug.