703235 - Remove ConsoleStorage

Status: RESOLVED FIXED

(DevTools :: Console, defect)

Description

[Sonny Piers [:sonny]]

bug 588871 "Remove ConsoleStorage methods used for log message storage" take into account that consolestorage is still used for webconsole filters config.

bug 62233 (patch waiting for review) makes consolestorage obsolete for filters config

So I propose to remove the ConsoleStorage code from HUDService.jsm

Comment 1

[Mihai Sucan [:msucan]]

Sounds good to me, but please wait for me to review bug 622303. :)

Comment 2

[Sonny Piers [:sonny]]

I already wrote the patch but I'll wait for the review to upload it.

Comment 3

[Mihai Sucan [:msucan]]

(In reply to Sonny Piers [:sonny] from comment #2)
> I already wrote the patch but I'll wait for the review to upload it.

Ah, then you can upload it!

Comment 4

[Sonny Piers [:sonny]]

Attachment: patch v1

Comment 5

[Sonny Piers [:sonny]]

Comment on attachment 575679 [details] [diff] [review]
patch v1

I cancelled the review because I taught I did something wrong but finally everything looks ok.

Sorry.

Comment 6

[Mihai Sucan [:msucan]]

Comment on attachment 575679 [details] [diff] [review]
patch v1

Review of attachment 575679 [details] [diff] [review]:
-----------------------------------------------------------------

This is a definite r+! THANK YOU very much Sonny! This is code clean up I wanted a long time ago! /me doing joy dance!

Great work Sonny!

Comment 8

[Rob Campbell [:rc] (:robcee)]

https://hg.mozilla.org/integration/fx-team/rev/3af9c38e8a52

Comment 9

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/3af9c38e8a52