Last Comment Bug 703718 - Unify dbg-server.js and dbg-server.jsm
: Unify dbg-server.js and dbg-server.jsm
Product: Firefox
Classification: Client Software
Component: Developer Tools: Debugger (show other bugs)
: Trunk
: All All
P3 normal (vote)
: Firefox 13
Assigned To: Dave Camp (:dcamp)
: Jason Laster [:jlast]
Depends on:
Blocks: minotaur 728796
  Show dependency treegraph
Reported: 2011-11-18 12:41 PST by Panos Astithas [:past]
Modified: 2012-02-19 23:23 PST (History)
1 user (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

merge dbg-server.js/jsm (26.73 KB, patch)
2012-02-10 16:03 PST, Dave Camp (:dcamp)
past: review+
Details | Diff | Splinter Review

Description User image Panos Astithas [:past] 2011-11-18 12:41:23 PST
Currently the debugger server goes to lengths to shield itself from other compartments, by creating a sandbox and populating with the server code. We should just have dbg-server.jsm with the current contents of dbg-server.js.
Comment 1 User image Panos Astithas [:past] 2011-12-12 02:19:49 PST
The rationale for this, as explained to me by dcamp, is that by the time we get to support the chrome debugging use case the JS engine will already have adequate protections in place that will render the sandbox approach redundant.
Comment 2 User image Dave Camp (:dcamp) 2012-02-10 16:03:56 PST
Created attachment 596208 [details] [diff] [review]
merge dbg-server.js/jsm

This is mostly a simple move of dbg-server.js -> dbg-server.jsm.  Diff is pretty dirty, sorry about that.  Needed to add EXPORTED_SYMBOLS and loadSubScript to dbg-server.js, everything else is just dbg-server.js.
Comment 3 User image Panos Astithas [:past] 2012-02-11 03:18:45 PST
Comment on attachment 596208 [details] [diff] [review]
merge dbg-server.js/jsm

Review of attachment 596208 [details] [diff] [review]:

Comment 4 User image Tim Taubert [:ttaubert] 2012-02-15 02:22:23 PST

Note You need to log in before you can comment on or make changes to this bug.