Unify dbg-server.js and dbg-server.jsm

RESOLVED FIXED in Firefox 13

Status

()

Firefox
Developer Tools: Debugger
P3
normal
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: past, Assigned: dcamp)

Tracking

Trunk
Firefox 13
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Currently the debugger server goes to lengths to shield itself from other compartments, by creating a sandbox and populating with the server code. We should just have dbg-server.jsm with the current contents of dbg-server.js.
The rationale for this, as explained to me by dcamp, is that by the time we get to support the chrome debugging use case the JS engine will already have adequate protections in place that will render the sandbox approach redundant.
Priority: -- → P3
(Assignee)

Comment 2

6 years ago
Created attachment 596208 [details] [diff] [review]
merge dbg-server.js/jsm

This is mostly a simple move of dbg-server.js -> dbg-server.jsm.  Diff is pretty dirty, sorry about that.  Needed to add EXPORTED_SYMBOLS and loadSubScript to dbg-server.js, everything else is just dbg-server.js.
Assignee: nobody → dcamp
Attachment #596208 - Flags: review?(past)
Comment on attachment 596208 [details] [diff] [review]
merge dbg-server.js/jsm

Review of attachment 596208 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.
Attachment #596208 - Flags: review?(past) → review+
https://hg.mozilla.org/mozilla-central/rev/5acf0e26ddcd
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 13
Blocks: 728796
You need to log in before you can comment on or make changes to this bug.