webconsole forces wacky lists on GCLI

RESOLVED FIXED in Firefox 12

Status

()

Firefox
Developer Tools: Console
P1
normal
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: jwalker, Assigned: jwalker)

Tracking

unspecified
Firefox 12
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Whenever GCLI uses an <li> element it gets a crazy bullet

The real problem is that list-item-type inherits, where -moz-image-region doesn't. So any <li> in GCLI's output look silly.
Assignee: nobody → jwalker
Status: NEW → ASSIGNED
Depends on: 704181
Created attachment 580018 [details] [diff] [review]
upload 1

This fixes bug 704181 and this bug

There are separate issues with fonts on linux which we're not tacking here. See bug 705109.

Half of me wants to split out the font declaration into font-size and font-family, just to be clearer, but I don't think that's policy, so I've left it as is.

I have not goune round and tested it on all platforms yet. Will do before r?
Attachment #580018 - Flags: feedback?(paul)
Attachment #580018 - Flags: feedback?(mihai.sucan)
Comment on attachment 580018 [details] [diff] [review]
upload 1

Review of attachment 580018 [details] [diff] [review]:
-----------------------------------------------------------------

Patch looks fine for me.
Attachment #580018 - Flags: feedback?(mihai.sucan) → feedback+

Comment 3

6 years ago
Comment on attachment 580018 [details] [diff] [review]
upload 1

You should delete this empty block:
.hud-msg-node {
}
Created attachment 580354 [details] [diff] [review]
upload 2


This fixes bug 704181 and this bug.

There are separate issues with fonts on linux which we're not tacking here. See bug 705109.

In essence we're moving:
* the font styling from hud-output-node and
* the bullet styling from hud-msg-node

and putting both bits of styling on webconsole-msg-body and the font styling on webconsole-timestamp.

It's fairly simple and had been looked at by mihai and paul already.

Thanks.

(fwiw https://tbpl.mozilla.org/?tree=Try&rev=50ee924570b4)
Attachment #580018 - Attachment is obsolete: true
Attachment #580018 - Flags: feedback?(paul)
Attachment #580354 - Flags: review?(dao)
Comment on attachment 580354 [details] [diff] [review]
upload 2

>+  font: 12px "DejaVu Sans Mono", monospace;

I don't understand why you're hard-coding a font size and family here, other than the generic monospace.
Attachment #580354 - Flags: review?(dao) → review-
(In reply to Dão Gottwald [:dao] from comment #5)
> Comment on attachment 580354 [details] [diff] [review]
> upload 2
> 
> >+  font: 12px "DejaVu Sans Mono", monospace;
> 
> I don't understand why you're hard-coding a font size and family here, other
> than the generic monospace.

As I said:

> There are separate issues with fonts on linux which we're not tacking here.
> See bug 705109.
Bug 705109 appears to be something different. It refers to Display.resizer.
Also, what I said isn't limited to Linux, and I don't see why you wouldn't handle it here in this bug that's specifically about fonts.
(In reply to Dão Gottwald [:dao] from comment #7)
> Bug 705109 appears to be something different. It refers to Display.resizer.
> Also, what I said isn't limited to Linux, and I don't see why you wouldn't
> handle it here in this bug that's specifically about fonts.

Sorry - wrong number. It's bug 706047.

That bug does not mention Linux, however the issues are not the same - if you take away the font names, on Linux, things look OK. On Windows/Mac, they look very broken.

Either way, this isn't relevant to this bug. Here we're solving the problem of web console specifying font in the wrong place. That bug is about fixing the way fonts are specified.
Hey Dão - This bug is still awaiting your attention. Please could you mark it r+ or address my reply in comment 8? Thanks!
Hey Dão, please could you take a quick look at this bug? Thanks.

Updated

6 years ago
Attachment #580354 - Flags: review- → review+
Blocks: 689605
https://tbpl.mozilla.org/?tree=Fx-Team&rev=9ea2996a1f3c
Whiteboard: [landed-in-fxteam]
https://hg.mozilla.org/mozilla-central/rev/8409adc46f14
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [landed-in-fxteam]
Target Milestone: --- → Firefox 12

Updated

6 years ago
Blocks: 717770

Updated

6 years ago
No longer blocks: 717770
Depends on: 717770
No longer depends on: 717770
You need to log in before you can comment on or make changes to this bug.