Last Comment Bug 704182 - webconsole forces wacky lists on GCLI
: webconsole forces wacky lists on GCLI
Status: RESOLVED FIXED
:
Product: Firefox
Classification: Client Software
Component: Developer Tools: Console (show other bugs)
: unspecified
: All All
: P1 normal (vote)
: Firefox 12
Assigned To: Joe Walker [:jwalker] (needinfo me or ping on irc)
:
:
Mentors:
Depends on: 704181
Blocks: 678152 GCLI-SHIP
  Show dependency treegraph
 
Reported: 2011-11-21 09:26 PST by Joe Walker [:jwalker] (needinfo me or ping on irc)
Modified: 2012-01-13 08:27 PST (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
upload 1 (2.98 KB, patch)
2011-12-08 05:39 PST, Joe Walker [:jwalker] (needinfo me or ping on irc)
mihai.sucan: feedback+
Details | Diff | Splinter Review
upload 2 (4.39 KB, patch)
2011-12-09 03:05 PST, Joe Walker [:jwalker] (needinfo me or ping on irc)
dao+bmo: review+
Details | Diff | Splinter Review

Description Joe Walker [:jwalker] (needinfo me or ping on irc) 2011-11-21 09:26:33 PST
Whenever GCLI uses an <li> element it gets a crazy bullet

The real problem is that list-item-type inherits, where -moz-image-region doesn't. So any <li> in GCLI's output look silly.
Comment 1 Joe Walker [:jwalker] (needinfo me or ping on irc) 2011-12-08 05:39:31 PST
Created attachment 580018 [details] [diff] [review]
upload 1

This fixes bug 704181 and this bug

There are separate issues with fonts on linux which we're not tacking here. See bug 705109.

Half of me wants to split out the font declaration into font-size and font-family, just to be clearer, but I don't think that's policy, so I've left it as is.

I have not goune round and tested it on all platforms yet. Will do before r?
Comment 2 Mihai Sucan [:msucan] 2011-12-08 08:23:17 PST
Comment on attachment 580018 [details] [diff] [review]
upload 1

Review of attachment 580018 [details] [diff] [review]:
-----------------------------------------------------------------

Patch looks fine for me.
Comment 3 Paul Rouget [:paul] 2011-12-08 11:03:08 PST
Comment on attachment 580018 [details] [diff] [review]
upload 1

You should delete this empty block:
.hud-msg-node {
}
Comment 4 Joe Walker [:jwalker] (needinfo me or ping on irc) 2011-12-09 03:05:45 PST
Created attachment 580354 [details] [diff] [review]
upload 2


This fixes bug 704181 and this bug.

There are separate issues with fonts on linux which we're not tacking here. See bug 705109.

In essence we're moving:
* the font styling from hud-output-node and
* the bullet styling from hud-msg-node

and putting both bits of styling on webconsole-msg-body and the font styling on webconsole-timestamp.

It's fairly simple and had been looked at by mihai and paul already.

Thanks.

(fwiw https://tbpl.mozilla.org/?tree=Try&rev=50ee924570b4)
Comment 5 Dão Gottwald [:dao] 2011-12-15 10:46:57 PST
Comment on attachment 580354 [details] [diff] [review]
upload 2

>+  font: 12px "DejaVu Sans Mono", monospace;

I don't understand why you're hard-coding a font size and family here, other than the generic monospace.
Comment 6 Joe Walker [:jwalker] (needinfo me or ping on irc) 2011-12-15 13:56:03 PST
(In reply to Dão Gottwald [:dao] from comment #5)
> Comment on attachment 580354 [details] [diff] [review]
> upload 2
> 
> >+  font: 12px "DejaVu Sans Mono", monospace;
> 
> I don't understand why you're hard-coding a font size and family here, other
> than the generic monospace.

As I said:

> There are separate issues with fonts on linux which we're not tacking here.
> See bug 705109.
Comment 7 Dão Gottwald [:dao] 2011-12-16 02:51:03 PST
Bug 705109 appears to be something different. It refers to Display.resizer.
Also, what I said isn't limited to Linux, and I don't see why you wouldn't handle it here in this bug that's specifically about fonts.
Comment 8 Joe Walker [:jwalker] (needinfo me or ping on irc) 2011-12-16 03:29:20 PST
(In reply to Dão Gottwald [:dao] from comment #7)
> Bug 705109 appears to be something different. It refers to Display.resizer.
> Also, what I said isn't limited to Linux, and I don't see why you wouldn't
> handle it here in this bug that's specifically about fonts.

Sorry - wrong number. It's bug 706047.

That bug does not mention Linux, however the issues are not the same - if you take away the font names, on Linux, things look OK. On Windows/Mac, they look very broken.

Either way, this isn't relevant to this bug. Here we're solving the problem of web console specifying font in the wrong place. That bug is about fixing the way fonts are specified.
Comment 9 Joe Walker [:jwalker] (needinfo me or ping on irc) 2011-12-21 06:23:34 PST
Hey Dão - This bug is still awaiting your attention. Please could you mark it r+ or address my reply in comment 8? Thanks!
Comment 10 Joe Walker [:jwalker] (needinfo me or ping on irc) 2011-12-24 04:29:41 PST
Hey Dão, please could you take a quick look at this bug? Thanks.
Comment 11 Joe Walker [:jwalker] (needinfo me or ping on irc) 2012-01-09 07:50:13 PST
https://tbpl.mozilla.org/?tree=Fx-Team&rev=9ea2996a1f3c
Comment 12 Tim Taubert [:ttaubert] 2012-01-10 14:48:45 PST
https://hg.mozilla.org/mozilla-central/rev/8409adc46f14

Note You need to log in before you can comment on or make changes to this bug.