704196 - demos: edit demo traceback

Status: VERIFIED FIXED

(developer.mozilla.org Graveyard :: Wiki pages, defect)

Description

[Luke Crouch [:groovecoder]]

1. Fresh database
2. Create a new demo with no tech nor challenge tags
3. Try to edit the demo.

Traceback (most recent call last):

  File "/Users/lcrouch/Sites/kuma/kuma/vendor/src/django/django/core/servers/basehttp.py", line 280, in run
    self.result = application(self.environ, self.start_response)

  File "/Users/lcrouch/Sites/kuma/kuma/vendor/src/django/django/core/servers/basehttp.py", line 674, in __call__
    return self.application(environ, start_response)

  File "/Users/lcrouch/Sites/kuma/kuma/vendor/src/django/django/core/handlers/wsgi.py", line 248, in __call__
    response = self.get_response(request)

  File "/Users/lcrouch/Sites/kuma/kuma/vendor/src/django/django/core/handlers/base.py", line 141, in get_response
    return self.handle_uncaught_exception(request, resolver, sys.exc_info())

  File "/Users/lcrouch/Sites/kuma/kuma/vendor/src/django/django/core/handlers/base.py", line 100, in get_response
    response = callback(request, *callback_args, **callback_kwargs)

  File "/Users/lcrouch/Sites/kuma/kuma/apps/demos/views.py", line 264, in edit
    form = SubmissionEditForm(instance=submission, request_user=request.user)

  File "/Users/lcrouch/Sites/kuma/kuma/apps/demos/forms.py", line 143, in __init__
    if instance.challenge_closed():

  File "/Users/lcrouch/Sites/kuma/kuma/apps/demos/models.py", line 552, in challenge_closed
    return challenge_utils.challenge_closed(challenge_tags)

  File "/Users/lcrouch/Sites/kuma/kuma/apps/demos/challenge_utils.py", line 47, in challenge_closed
    return datetime.date.today() > max(map(challenge_tag_to_end_date, tags))

  File "/Users/lcrouch/Sites/kuma/kuma/apps/demos/challenge_utils.py", line 38, in challenge_tag_to_end_date
    year, month = challenge_tag_to_date_parts(tag)

  File "/Users/lcrouch/Sites/kuma/kuma/apps/demos/challenge_utils.py", line 28, in challenge_tag_to_date_parts
    year, month = str(tag).split(':')[1:]

ValueError: need more than 1 value to unpack

Comment 1

[Luke Crouch [:groovecoder]]

We're getting this a bunch from production now. Let's make sure to get it done by Tuesday code-"slush"

Comment 5

[[github robot]]

Commits pushed to https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/5ac3a6aeee53115ac3c6df3738e23f1fe57f37ab
Bug 704196: fix a subtle problem that crept up when editing a submission with no tags.

https://github.com/mozilla/kuma/commit/87fd07c9c13e506dec6a270f495e72fdc0dac0c9
Merge pull request #60 from ubernostrum/672962-devderby-editing

Bug 704196: fix a subtle problem that crept up when editing a submission...

Comment 7

[[github robot]]

Commit pushed to https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/85b54f2b612f62c8c592bddce13702343093ba8b
Bug 704196: fix a subtle problem that crept up when editing a submission with no tags.

Comment 8

[raymond [:retornam] (inactive)]

verified fixed https://developer.mozilla.org/en-US/demos/