Flash content does not have a placeholder if on Android 3.x

VERIFIED FIXED

Status

()

Firefox for Android
General
P1
normal
VERIFIED FIXED
6 years ago
10 months ago

People

(Reporter: kbrosnan, Assigned: blassey)

Tracking

unspecified
ARM
Android
Points:
---

Firefox Tracking Flags

(firefox11 fixed, fennec11+)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Reporter)

Description

6 years ago
On 2.1, 3.x and 4.0 we are not creating the placeholder for flash content on a page.
Here is a test page for flash: http://people.mozilla.com/~mwargers/tests/flash/flashembed.html
(Assignee)

Updated

6 years ago
Priority: -- → P1
Margaret can you reproduce this?
Assignee: nobody → margaret.leibovic

Comment 3

6 years ago
I see the missing plugin UI. Tested on a Galaxy S (2.3) and Galaxy Nexus (4).
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → WORKSFORME
(Reporter)

Updated

6 years ago
Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---
(Reporter)

Comment 4

6 years ago
I still see this on today's nightly using my Transformer.
Status: REOPENED → NEW
Summary: Flash content does not have a placeholder if on a unsupported device or flash is not installed → Flash content does not have a placeholder if on Android 3.x
(Reporter)

Comment 5

6 years ago
Created attachment 580490 [details]
Screenshot

Since this is Honeycomb only I doubt this is a P1.
Created attachment 580574 [details] [diff] [review]
patch

So, technically, this is correct. The reason there's no placeholder is because there is a flash plugin on the system an we're loading and initializing it. But, because its honeycomb, we can't draw anything. This patch will prevent us from finding any plugins on honeycomb (and ICS).

Madhava, we might want to have different text in the placeholder for these platforms. Something to the effect of "Plugins are not supported on this platform" rather than "A plugin is needed to display this content"
Assignee: margaret.leibovic → blassey.bugs
Created attachment 580575 [details] [diff] [review]
patch

damnit, wrong patch
Attachment #580574 - Attachment is obsolete: true
Attachment #580575 - Flags: review?(snorp)
Attachment #580575 - Flags: review?(snorp) → review+
pushed https://hg.mozilla.org/mozilla-central/rev/202f4ccbbda1
Status: NEW → RESOLVED
Last Resolved: 6 years ago6 years ago
Resolution: --- → FIXED

Updated

6 years ago
Whiteboard: [QA+]
Duplicate of this bug: 695826
(Assignee)

Updated

5 years ago
tracking-fennec: --- → 11+
(Assignee)

Updated

5 years ago
status-firefox11: --- → fixed
(In reply to Brad Lassey [:blassey] from comment #6)
> Madhava, we might want to have different text in the placeholder for these
> platforms. Something to the effect of "Plugins are not supported on this
> platform" rather than "A plugin is needed to display this content"

I filed bug 725286 for this.

Comment 11

5 years ago
Verified on:
Nightly Fennec 13.0a1 (2012-03-04)
Devices: HTC Desire Z (Android 2.3.3), Galaxy Nexus (Android 4.0), Acer A500(Android 3.2)
Status: RESOLVED → VERIFIED

Updated

5 years ago
Whiteboard: [QA+]
You need to log in before you can comment on or make changes to this bug.