Closed Bug 704721 Opened 8 years ago Closed 8 years ago

[ICS/Honeycomb] - VKB backspace key dismisses keyboard and deletes two characters only on the URL bar

Categories

(Firefox for Android :: General, defect, major)

ARM
Android
defect
Not set
major

Tracking

()

VERIFIED FIXED

People

(Reporter: aaronmt, Assigned: alexp)

Details

(Whiteboard: [VKB])

Attachments

(1 file)

Currently when one presses the VKB backspace key in the URL bar, it will dismiss the VKB (in both landscape and portrait views) regardless of text, carat position or empty value.

I am using the AOSP ICS release for the Nexus S from XDA.

This is using stock Android keyboard (US).

--
Samsung Nexus S (Android 4.0.1)
20111122164730
http://hg.mozilla.org/projects/birch/rev/ff5faa59c065
Note, it seems like two events are happening actually: a delete *is* performed (i.e, google.com becomes google.co) alongside the VKB dismissing after.
Summary: [ICS] - VKB backspace key dismisses keyboard → [ICS] - VKB backspace key dismisses keyboard only on the URL bar
This happens on the galaxy tab too, running Android 3.1.

Backspace in the url bar deletes two characters and dismisses the vkb.
This is a major barrier towards using the browser as a daily driver.
Severity: normal → major
Summary: [ICS] - VKB backspace key dismisses keyboard only on the URL bar → [ICS/Honeycomb] - VKB backspace key dismisses keyboard and deletes two characters only on the URL bar
Attached patch FixSplinter Review
This should resolve the problem. It does fix the double-delete on Honeycomb, but I did not see the dismissing of the keyboard neither before nor after this patch.
I also don't have an ICS device to test this.
Assignee: nobody → alexp
Status: NEW → ASSIGNED
Attachment #576840 - Flags: review?(blassey.bugs)
Can someone test this build on ICS please: http://people.mozilla.org/~alexp/bug/704721-backspace/fennec-11.0a1.en-US.android-arm.apk
Thanks.
Whiteboard: vkb → [VKB]
I've just confirmed the regression was introduced by a workaround fix in bug 697773. The double-deletion in awesomebar on Honeycomb is observed first time in the build 20111115040200 (97283e503e1e). My fix here is exactly for that part of code.
Attachment #576840 - Flags: review?(blassey.bugs) → review+
(In reply to Alex Pakhotin (:alexp) from comment #5)
> Can someone test this build on ICS please:
> http://people.mozilla.org/~alexp/bug/704721-backspace/fennec-11.0a1.en-US.
> android-arm.apk
> Thanks.

Trying this out now.
Works, thanks Alex.
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Samsung Nexus S (Android 4.0.1)
20111125040216
http://hg.mozilla.org/projects/birch/rev/2aec00aaf211
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.