704721 - [ICS/Honeycomb] - VKB backspace key dismisses keyboard and deletes two characters only on the URL bar

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Aaron Train [:aaronmt]]

Currently when one presses the VKB backspace key in the URL bar, it will dismiss the VKB (in both landscape and portrait views) regardless of text, carat position or empty value.

I am using the AOSP ICS release for the Nexus S from XDA.

This is using stock Android keyboard (US).

--
Samsung Nexus S (Android 4.0.1)
20111122164730
http://hg.mozilla.org/projects/birch/rev/ff5faa59c065

Comment 1

[Aaron Train [:aaronmt]]

Note, it seems like two events are happening actually: a delete *is* performed (i.e, google.com becomes google.co) alongside the VKB dismissing after.

Comment 2

[Mark Reid [:mreid]]

This happens on the galaxy tab too, running Android 3.1.

Backspace in the url bar deletes two characters and dismisses the vkb.

Comment 3

[Aaron Train [:aaronmt]]

This is a major barrier towards using the browser as a daily driver.

Comment 4

[Alex Pakhotin (:alexp)]

Attachment: Fix

This should resolve the problem. It does fix the double-delete on Honeycomb, but I did not see the dismissing of the keyboard neither before nor after this patch.
I also don't have an ICS device to test this.

Comment 5

[Alex Pakhotin (:alexp)]

Can someone test this build on ICS please: http://people.mozilla.org/~alexp/bug/704721-backspace/fennec-11.0a1.en-US.android-arm.apk
Thanks.

Comment 6

[Alex Pakhotin (:alexp)]

I've just confirmed the regression was introduced by a workaround fix in bug 697773. The double-deletion in awesomebar on Honeycomb is observed first time in the build 20111115040200 (97283e503e1e). My fix here is exactly for that part of code.

Comment 7

[Aaron Train [:aaronmt]]

(In reply to Alex Pakhotin (:alexp) from comment #5)
> Can someone test this build on ICS please:
> http://people.mozilla.org/~alexp/bug/704721-backspace/fennec-11.0a1.en-US.
> android-arm.apk
> Thanks.

Trying this out now.

Comment 8

[Alex Pakhotin (:alexp)]

http://hg.mozilla.org/projects/birch/rev/2aec00aaf211

Comment 9

[Aaron Train [:aaronmt]]

Works, thanks Alex.

Comment 10

[Aaron Train [:aaronmt]]

Samsung Nexus S (Android 4.0.1)
20111125040216
http://hg.mozilla.org/projects/birch/rev/2aec00aaf211