Closed
Bug 697773
Opened 14 years ago
Closed 14 years ago
Cannot type in AwesomeBar URL bar with hard keyboard
Categories
(Firefox for Android Graveyard :: General, defect, P1)
Tracking
(firefox11 fixed, fennec11+)
VERIFIED
FIXED
People
(Reporter: bnicholson, Assigned: alexp)
References
Details
(Whiteboard: [HKB][testday-20111111])
Attachments
(1 file, 2 obsolete files)
1.56 KB,
patch
|
blassey
:
review+
|
Details | Diff | Splinter Review |
Trying to type in the AwesomeBar with the Droid Pro (with hard keyboard) doesn't work. The URL bar simply loses focus when a character is pressed.
Reporter | ||
Updated•14 years ago
|
Summary: Cannot type in AwesomeBar URL with hard keyboard → Cannot type in AwesomeBar URL bar with hard keyboard
Comment 1•14 years ago
|
||
I am running into this while trying to use monkey runner
Comment 2•14 years ago
|
||
Brian, could you try latest birch and tell me if this still happens. I've just pushed a focus-related fix (bug 697121) which might be related to this bug. Can you see where the focus goes once the URL text entry loses focus?
WFM on droid pro with latest nightly birch.
Reporter | ||
Comment 4•14 years ago
|
||
Yes, I'm still seeing this bug. I don't know where the focus goes - it doesn't look like anything has focus.
Reporter | ||
Comment 5•14 years ago
|
||
After installing a soft keyboard and setting "Input method" to the soft keyboard in the Android settings, the hard keyboard works.
I noticed that I used the simeji IME on the Droid Pro and that's why it worked.
On the Droid 2 with the default IME (Multi-touch Keyboard), the hardware keyboard did not work.
I just realized, given bug 698131; the focus is on the first line of the list. The first item is highlighted because it's all white.
Comment 8•14 years ago
|
||
using the latest build from birch, I am unable to get this to work :(
Comment 9•14 years ago
|
||
Seeing as how this renders the browser completely useless without the ability to invoke a virtual keyboard on such a device (and probably dozens akin), this should have a high priority.
Comment 10•14 years ago
|
||
i just experienced this on birch nightly from this morning on my G2, the soft keyboard works fine but i can't type in the URL bar with the physical keyboard. basically commenting to say G2 has the same problem. the focus drops down to the first entry under "All Pages" (it's highlighted).
Updated•14 years ago
|
Assignee: nobody → alexp
Updated•14 years ago
|
Priority: -- → P1
Assignee | ||
Updated•14 years ago
|
Whiteboard: [HKB]
Assignee | ||
Comment 12•14 years ago
|
||
Confirmed with Motorola Droid 3.
Now I've got a phone with keyboard and I'm working on this.
Assignee | ||
Comment 13•14 years ago
|
||
The TabHost somehow steals the focus from the edit box on keyboard input.
The fix is to explicitly request the focus when the awesome screen opens and when the edit box is touched.
Attachment #573054 -
Flags: review?(blassey.bugs)
Updated•14 years ago
|
Attachment #573054 -
Flags: review?(blassey.bugs) → review+
Assignee | ||
Comment 14•14 years ago
|
||
Assignee | ||
Updated•14 years ago
|
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Comment 15•14 years ago
|
||
Just adding Sriram and Lucas to CC in case something in the Awesombar.java or AwesombarTabs.java is doing the focus thing on purpose.
We do things like http://hg.mozilla.org/projects/birch/rev/365da62068e0
and: http://mxr.mozilla.org/projects-central/source/birch/embedding/android/AwesomeBar.java#107
I just want to make sure we aren't fighting code we added on purpose. If we are, we need to make sure we aren't cancelling anything out.
Assignee | ||
Comment 16•14 years ago
|
||
In this case the stealing of the focus happened before any AwesomeBar listeners got called, which made the bug especially difficult to understand.
Assignee | ||
Comment 17•14 years ago
|
||
By the way, I should have mentioned: this bug was not really a regression, but rather an unexpected side-effect of a new feature added in the bug 695307, specifically - the AwesomeBarTabs. JFYI.
Comment 18•14 years ago
|
||
(In reply to Alex Pakhotin (:alexp) from comment #17)
> By the way, I should have mentioned: this bug was not really a regression,
> but rather an unexpected side-effect of a new feature added in the bug
> 695307, specifically - the AwesomeBarTabs. JFYI.
Just make sure soft keyboard is hidden when switching tabs or whenever the text entry loses focus.
Comment 19•14 years ago
|
||
20111109040505
http://hg.mozilla.org/projects/birch/rev/edd8921d5bb8
Motorola Droid Pro (Android 2.3)
Filed bug 701018 as another issue with the Motorola Droid Pro
Status: RESOLVED → VERIFIED
Comment 20•14 years ago
|
||
This busted accessing virtual keyboard on landscape: bug 701021, touch input bug 701020, and maybe bug 701018.
Updated•14 years ago
|
Status: VERIFIED → REOPENED
Resolution: FIXED → ---
Comment 21•14 years ago
|
||
I suggest to back out this patch until there's a clean fix for this bug.
Comment 22•14 years ago
|
||
why did you reopen this bug? The patch fixed the bug in question. Do not reopen unless there's been a back out
Status: REOPENED → RESOLVED
Closed: 14 years ago → 14 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 23•14 years ago
|
||
The patch does fix the bug as described, but unfortunately does break the touch mode. :( I tested the basic things with VKB and it seemed to work, but apparently not in all cases.
The problem here is with TabHost, which our AwesomeBarTabs is based on. It steals the focus when it shouldn't. It's actually a known issue: http://code.google.com/p/android/issues/detail?id=2516
I used the workaround mentioned there, but apparently it has too many bad side-effects.
Assignee | ||
Comment 24•14 years ago
|
||
Backed out due to VKB regressions. Need another solution.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 25•14 years ago
|
||
OK, this looks like the real fix. The hardware keyboard works, and I don't see any of those issues appeared after the first version.
Attachment #573054 -
Attachment is obsolete: true
Attachment #573761 -
Flags: review?(blassey.bugs)
Comment 26•14 years ago
|
||
I guess this is also the reason that it is impossible to use the vkb or the normal keyboard in native Fennec on the Android emulator?
Whiteboard: [HKB] → [HKB][testday-20111111]
Updated•14 years ago
|
Attachment #573761 -
Flags: review?(blassey.bugs) → review+
Comment 27•14 years ago
|
||
I'm able to confirm this case on 20111111 nightly for testday.
Motorola Droid Pro, Android 2.2
Comment 28•14 years ago
|
||
(In reply to Martijn Wargers [:mw22] (QA - IRC nick: mw22) from comment #26)
> I guess this is also the reason that it is impossible to use the vkb or the
> normal keyboard in native Fennec on the Android emulator?
I do have the same issue on the emulator. Very likely related to this problem here, as the symptoms are exactly the same as with android on tegra with USB hardware keyboard attached.
Assignee | ||
Comment 29•14 years ago
|
||
Status: REOPENED → RESOLVED
Closed: 14 years ago → 14 years ago
Resolution: --- → FIXED
Comment 30•14 years ago
|
||
Comment 31•14 years ago
|
||
Comment on attachment 574348 [details] [diff] [review]
Cannot type in AwesomeBar URL bar with hard keyboard.
bzexport fail
Attachment #574348 -
Attachment is obsolete: true
Comment 32•14 years ago
|
||
20111115055623
http://hg.mozilla.org/projects/birch/rev/6b776bed41d7
Motorola Droid Pro (Android 2.3)
Status: RESOLVED → VERIFIED
Comment 33•14 years ago
|
||
this works on my Android 2.3 G2 in today's nightly as well :)
Updated•14 years ago
|
tracking-fennec: --- → 11+
Updated•14 years ago
|
status-firefox11:
--- → fixed
Updated•5 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•