Created attachment 576821 [details] [diff] [review]
It's some nice cleanup, but I'm not sure if JS_GetGlobalObject(aCx) is correct (or even what behaviour these methods want, and how that correlates with JSAPI).
JS_GetGlobalObject is almost certainly different from what we used to do if the code that's running doesn't have the same global as the context it's running on (think cross-window call).
I'm not exactly comfortable with this review; who touched this code last?
sayrer, email@example.com, jst, and, well, you. How about I leave the global-getting code alone and just clean up the arguments-converting code?
Gah. Are you serious? Can I still disclaim responsibility somehow?
Leaving the global stuff alone and cleaning up the argument mess sounds great.
Created attachment 578859 [details] [diff] [review]
Let's try this...
Comment on attachment 578859 [details] [diff] [review]