705188 - Use IDL for mozIJSSubScriptLoader::LoadSubScript, {xpcIJSModuleLoader,nsIXPCComponents_Utils}::Import

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v1

It's some nice cleanup, but I'm not sure if JS_GetGlobalObject(aCx) is correct (or even what behaviour these methods want, and how that correlates with JSAPI).

Comment 1

[Boris Zbarsky [:bzbarsky]]

JS_GetGlobalObject is almost certainly different from what we used to do if the code that's running doesn't have the same global as the context it's running on (think cross-window call).

I'm not exactly comfortable with this review; who touched this code last?

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

sayrer, [e-mail], jst, and, well, you. How about I leave the global-getting code alone and just clean up the arguments-converting code?

Comment 3

[Boris Zbarsky [:bzbarsky]]

Gah.  Are you serious?  Can I still disclaim responsibility somehow?

Leaving the global stuff alone and cleaning up the argument mess sounds great.

Comment 4

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v2

Let's try this...

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 578859 [details] [diff] [review]
Patch v2

r=me

Comment 6

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/93ab106616a2