The default bug view has changed. See this FAQ.

Use IDL for mozIJSSubScriptLoader::LoadSubScript, {xpcIJSModuleLoader,nsIXPCComponents_Utils}::Import

RESOLVED FIXED in mozilla11

Status

()

Core
XPConnect
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Ms2ger, Assigned: Ms2ger)

Tracking

Trunk
mozilla11
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
Created attachment 576821 [details] [diff] [review]
Patch v1

It's some nice cleanup, but I'm not sure if JS_GetGlobalObject(aCx) is correct (or even what behaviour these methods want, and how that correlates with JSAPI).
Attachment #576821 - Flags: review?(bzbarsky)
(Assignee)

Updated

5 years ago
Blocks: 705324
JS_GetGlobalObject is almost certainly different from what we used to do if the code that's running doesn't have the same global as the context it's running on (think cross-window call).

I'm not exactly comfortable with this review; who touched this code last?
(Assignee)

Comment 2

5 years ago
sayrer, rginda@netscape.com, jst, and, well, you. How about I leave the global-getting code alone and just clean up the arguments-converting code?
Summary: Use IDL for {mozIJSSubScriptLoader,xpcIJSModuleLoader,nsIXPCComponents_Utils}::Import → Use IDL for mozIJSSubScriptLoader::LoadSubScript, {xpcIJSModuleLoader,nsIXPCComponents_Utils}::Import
Gah.  Are you serious?  Can I still disclaim responsibility somehow?

Leaving the global stuff alone and cleaning up the argument mess sounds great.
(Assignee)

Comment 4

5 years ago
Created attachment 578859 [details] [diff] [review]
Patch v2

Let's try this...
Attachment #576821 - Attachment is obsolete: true
Attachment #576821 - Flags: review?(bzbarsky)
Attachment #578859 - Flags: review?(bzbarsky)
Comment on attachment 578859 [details] [diff] [review]
Patch v2

r=me
Attachment #578859 - Flags: review?(bzbarsky) → review+
(Assignee)

Comment 6

5 years ago
https://hg.mozilla.org/mozilla-central/rev/93ab106616a2
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla11
You need to log in before you can comment on or make changes to this bug.